<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9827" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>That looks really good!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9827#inline-44728" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Badge.qml:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">implicitWidth:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">height</span><span class="p">,</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">round</span><span class="p">(</span><span style="color: #004012">label</span><span class="p">.</span><span style="color: #004012">contentWidth</span> <span style="color: #aa2211">+</span> <span style="color: #004012">radius</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">))</span> <span style="color: #74777d">// Add some padding around.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">height:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">round</span><span class="p">(</span><span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.4</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">color:</span> <span style="color: #004012">theme</span><span class="p">.</span><span style="color: #004012">highlightColor</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Components shouldn't specify their own height, nor should they assume stuff about their parents, it makes them non-portable.</p>

<p style="padding: 0; margin: 8px;">I would get rid of this line. Maybe specify an implicitHeight of: label.implicitHeight.</p>

<p style="padding: 0; margin: 8px;">Apperance will remain identical as you're overwriting the height on line 79 of TaskBadgeOverlay</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9827#inline-44732" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Badge.qml:48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">text:</span> <span style="color: #004012">badgeRect</span><span class="p">.</span><span style="color: #004012">number</span> <span style="color: #aa2211">></span> <span style="color: #601200">9999</span> <span style="color: #aa2211">?</span> <span style="color: #004012">i18nc</span><span class="p">(</span><span style="color: #766510">"Over 9999 new messages, overlay, keep short"</span><span class="p">,</span> <span style="color: #766510">"9,999+"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                      <span style="color: #aa2211">:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">badgeRect</span><span class="p">.</span><span style="color: #004012">number</span><span class="p">).</span><span style="color: #004012">toLocaleString</span><span class="p">(</span><span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">locale</span><span class="p">(),</span> <span style="color: #766510">'f'</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why 0 instead of a negative?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9827" rel="noreferrer">https://phabricator.kde.org/D9827</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, hein<br /><strong>Cc: </strong>davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>