<table><tr><td style="">romangg added a comment.<br />Restricted Application edited projects, added KWin; removed Plasma.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9699" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Are there maybe other cases of clients in X, which share the same group, are not transient, but need to have <tt style="background: #ebebeb; font-size: 13px;">isActiveFullScreen</tt> return true on any client if one of them is the most recent activated one?</p>

<p>I mean you change the behavior now from testing on the group to only testing on the transient property, what seems to make sense. But what was the reason to set <tt style="background: #ebebeb; font-size: 13px;">isActiveFullScreen</tt> to true for clients sharing the same group in the first place?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9699#inline-43982" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">abstract_client.cpp:1155</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// we'll also take the screen into account</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span class="n">ac</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span class="n">ac</span> <span style="color: #aa2211">==</span> <span style="color: #aa4000">this</span> <span style="color: #aa2211">||</span> <span class="n">ac</span><span style="color: #aa2211">-></span><span class="n">screen</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span class="n">screen</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span class="n">ac</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span class="n">ac</span> <span style="color: #aa2211">==</span> <span style="color: #aa4000">this</span> <span style="color: #aa2211">||</span> <span class="n">ac</span><span style="color: #aa2211">-></span><span class="n">screen</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span class="n">screen</span><span class="p">()<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">ac</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">transientFor</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">this</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Just a question for understanding unrelated to this patch: why should <tt style="background: #ebebeb; font-size: 13px;">isActiveFullScreen</tt> return true, if <tt style="background: #ebebeb; font-size: 13px;">ac->screen() != screen()</tt>? We don't know if it's really active just because it's on another screen than the one which the most recently activated client is on.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9699" rel="noreferrer">https://phabricator.kde.org/D9699</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: </strong>romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>