<table><tr><td style="">zzag updated this revision to Diff 24849.<br />zzag added a comment.<br />Restricted Application edited projects, added KWin; removed Plasma.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9391" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Updating <a href="https://phabricator.kde.org/D9391" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9391</a>: [effects] Add 'Fullscreen' effect</p>

<p>Re-implemented this effect. The only missing part is emitters of <tt style="background: #ebebeb; font-size: 13px;">windowFullScreenChanged</tt><br />
signal. For development I've made stub in <tt style="background: #ebebeb; font-size: 13px;">void EffectsHandlerImpl::setupClientConnections(Client* c)</tt>:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">cpp
connect(c, &AbstractClient::fullScreenChanged, this,
        [this, c]() {
            bool entered = c->isFullScreen();
            QRect oldGeometry = entered
                ? c->geometryFSRestore()
                : QRect(0, 0, 1366, 768); // 1366x768 my screen resolution :(
            emit windowFullScreenChanged(c->effectWindow(), entered, oldGeometry);
        });</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D9391?vs=24718&id=24849" rel="noreferrer">https://phabricator.kde.org/D9391?vs=24718&id=24849</a></div></div><br /><div><strong>BRANCH</strong><div><div>effects/fullscreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9391" rel="noreferrer">https://phabricator.kde.org/D9391</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/test_builtin_effectloader.cpp<br />
autotests/test_plugin_effectloader.cpp<br />
autotests/test_scripted_effectloader.cpp<br />
effects/CMakeLists.txt<br />
effects/effect_builtins.cpp<br />
effects/effect_builtins.h<br />
effects/fullscreen/CMakeLists.txt<br />
effects/fullscreen/fullscreen.cpp<br />
effects/fullscreen/fullscreen.h<br />
effects/fullscreen/timeline.h<br />
libkwineffects/kwineffects.h</div></div></div><br /><div><strong>To: </strong>zzag, KWin, Plasma, graesslin<br /><strong>Cc: </strong>abetts, graesslin, broulik, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart<br /></div>