<table><tr><td style="">zzag updated this revision to Diff 24718.<br />zzag added a comment.<br />Restricted Application edited projects, added Plasma; removed KWin.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9391" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Updating <a href="https://phabricator.kde.org/D9391" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9391</a>: [effects] Add 'Fullscreen' effect</p>

<p>I think this should be rewritten in C++ for several reasons:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">we need to control timeline</li>
<li class="remarkup-list-item">when entering or leaving fullscreen mode, we should handle docks in a special way and I don't really think it is possible with js api</li>
</ul>

<p>Also, please notice that signature of <tt style="background: #ebebeb; font-size: 13px;">windowFullScreenChanged</tt> has changed.<br />
Now, it also includes previous geometry of a window. This plus several changes<br />
in <tt style="background: #ebebeb; font-size: 13px;">geometry.cpp</tt> and <tt style="background: #ebebeb; font-size: 13px;">shell_client.cpp</tt> should result in a generic<br />
fullscreen effect, I hope.</p>

<p>PLEASE NOTICE THAT'S JUST A STUB, IT DOES NOTHING! (I'm intrested in feedback)</p>

<p>Also, seems like Qt have a bug. If you enter/leave fullscreen mode in any<br />
Qt app, <tt style="background: #ebebeb; font-size: 13px;">ShellClient::setFullScreen</tt> is not called.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D9391?vs=24524&id=24718" rel="noreferrer">https://phabricator.kde.org/D9391?vs=24524&id=24718</a></div></div><br /><div><strong>BRANCH</strong><div><div>effects/fullscreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9391" rel="noreferrer">https://phabricator.kde.org/D9391</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>effects/CMakeLists.txt<br />
effects/effect_builtins.cpp<br />
effects/effect_builtins.h<br />
effects/fullscreen/CMakeLists.txt<br />
effects/fullscreen/fullscreen.cpp<br />
effects/fullscreen/fullscreen.h<br />
libkwineffects/kwineffects.h</div></div></div><br /><div><strong>To: </strong>zzag, KWin, Plasma, graesslin<br /><strong>Cc: </strong>abetts, graesslin, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>