<table><tr><td style="">Zren added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9201" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>So you removed 2 units from the overall cell height, but only 1 unit from the frameloader height. This means you removed 1 unit from the "leftover" padding at the bottom of the frameloader, and are overlapping the cell below by another 1 unit.</p>
<p>Before (cellHeight=6 units, top margin=1 unit, frameloader=5 units)</p>
<p><a href="https://phabricator.kde.org/F5614507" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5614507: 2018-01-02___17-31-05.png</a></p>
<p>After (cellHeight=4 units, top margin=1 unit, frameloader=4 units)</p>
<p><a href="https://phabricator.kde.org/F5614547" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5614547: 2018-01-02___17-37-27.png</a></p>
<p>It's much more obvious when we zoom in.</p>
<p><a href="https://phabricator.kde.org/F5614553" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5614553: 2018-01-02___17-39-04.png</a></p>
<h2 class="remarkup-header">How to fix:</h2>
<p><strong>Option A)</strong> Remove just 1 unit of padding from the bottom of the frameloader.</p>
<p>Add 1 unit to the cellHeight. (cellHeight=5 units, top margin=1 unit, frameloader=4 units)</p>
<p>This makes it look weird, since there's 2 units of top padding, and only 1 unit of bottom padding.</p>
<p><strong>Option B)</strong> Remove 1 unit from the top padding, and 1 unit from the bottom padding of the frameloader.</p>
<p>Remove 1 more unit from <tt style="background: #ebebeb; font-size: 13px;">icon.anchors.topMargin</tt></p>
<p>From</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">PlasmaCore.IconItem {
id: icon
anchors {
topMargin: (2 * units.smallSpacing)
leftMargin: units.smallSpacing
}</pre></div>
<p>to</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">PlasmaCore.IconItem {
id: icon
anchors {
topMargin: units.smallSpacing
leftMargin: units.smallSpacing
}</pre></div>
<p>and change the <tt style="background: #ebebeb; font-size: 13px;">frameLoader.height</tt> calculation</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Loader {
id: frameLoader
height: {
if (root.useListViewMode) {
return parent.height;
}
// Note: frameLoader.y = units.smallSpacing (acts as top margin)
return (units.smallSpacing // icon.anchors.topMargin (acts as top padding)
+ icon.height
+ units.smallSpacing // label.anchors.topMargin (acts as spacing between icon and label)
+ (label.lineCount * theme.mSize(theme.defaultFont).height)
+ units.smallSpacing); // leftover (acts as bottom padding)
}</pre></div>
<p><a href="https://phabricator.kde.org/F5614585" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F5614585: 2018-01-02___18-03-18.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9201" rel="noreferrer">https://phabricator.kde.org/D9201</a></div></div><br /><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>abetts, Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>