<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9459" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks good, some nitpicking.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9459#inline-42877" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appearancegtk3.cpp:46</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright">    </span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">hasGtkrc</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">QStringList</span></span><span class="bright"> </span><span class="n"><span class="bright">gtk3SubdirPattern</span></span><span class="bright"></span><span class="p"><span class="bright">{</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"gtk-3.*"</span></span><span class="bright"></span><span class="p"><span class="bright">)};</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span><span class="p">(</span><span class="n">QFileInfoList</span><span style="color: #aa2211">::</span><span class="n">iterator</span> <span class="n">it</span><span style="color: #aa2211">=</span><span class="n">availableThemes</span><span class="p">.</span><span class="n">begin</span><span class="p">();</span> <span class="n">it</span><span style="color: #aa2211">!=</span><span class="n">availableThemes</span><span class="p">.</span><span class="n">end</span><span class="p">();</span> <span style="color: #aa2211">++</span><span class="n">it</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QDir</span> <span class="n">themeDir</span><span class="p">(</span><span class="n">it</span><span style="color: #aa2211">-></span><span class="n">filePath</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">constBegin/constEnd</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9459#inline-42878" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appearancegtk3.cpp:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">themeDir</span><span class="p">.</span><span class="n">setNameFilters</span><span class="p">(</span><span class="n">gtk3SubdirPattern</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">themeDir</span><span class="p">.</span><span class="n">entryList</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">Dirs</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">themes</span> <span style="color: #aa2211">+=</span> <span class="n">it</span><span style="color: #aa2211">-></span><span class="n">filePath</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The name filters can be the first argument here</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R99 KDE Gtk Configuration Tool</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9459" rel="noreferrer">https://phabricator.kde.org/D9459</a></div></div><br /><div><strong>To: </strong>fvogt, Plasma, lbeltrame, apol<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>