<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9240" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9240#inline-41556" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">runnermanager.cpp:107</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">maxThreads</span> <span style="color: #aa2211">=</span> <span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"maxThreads"</span><span class="p">,</span> <span style="color: #601200">16</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">numThreads</span> <span style="color: #aa2211">=</span> <span class="n">qMin</span><span class="p">(</span><span class="n">maxThreads</span><span class="p">,</span> <span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="p"><span class="bright">((</span></span><span class="bright"></span><span class="n"><span class="bright">numProcs</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">2</span></span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">        </span><span style="color: #74777d"><span class="bright">//qCDebug(KRUNNER) << "setting up" << numThreads << "threads for" << numProcs << "processors";</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">numThreads</span> <span style="color: #aa2211">=</span> <span class="n">qMin</span><span class="p">(</span><span class="n">maxThreads</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">QThread</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">idealThreadCount</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Or should we keep this weird logic and substitute <tt style="background: #ebebeb; font-size: 13px;">numProcs</tt> for <tt style="background: #ebebeb; font-size: 13px;">idealThreadCount</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R308 KRunner</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9240" rel="noreferrer">https://phabricator.kde.org/D9240</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, Frameworks<br /><strong>Cc: </strong>plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>