<table><tr><td style="">davidedmundson added a comment.<br />Restricted Application edited projects, added Plasma; removed KWin.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9216" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Imho the button should be there by default and shown if global menu is enabled in settings</p></blockquote>
<p>With that approach:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">users have an icon in the previews they can't see on their titlebar, which is weird.</li>
<li class="remarkup-list-item">users of the applet still have to do two steps</li>
<li class="remarkup-list-item">we still have that complex 4 possible options of having a button and the setting being enabled.</li>
</ul>
<p>From a technical POV, I much prefer this. Especially on the Applet version of this patch.</p>
<p>From a UI POV, there's nothing to stop the old KCM setting remaining and instead manipulating the kwin buttons / running a plasma script.<br />
IMHO it's not worth it, it's a far less intuitive place to look, but it's not something I'd object to either.</p>
<hr class="remarkup-hr" />
<p>As for this patch, code here is fine, but there's stuff that could then be removed.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9216" rel="noreferrer">https://phabricator.kde.org/D9216</a></div></div><br /><div><strong>To: </strong>mart, KWin, Plasma<br /><strong>Cc: </strong>davidedmundson, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>