<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9123" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9123#inline-41229" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">applet.cpp:98</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa2211">:</span>  <span class="n">QObject</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">       <span class="n">d</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">AppletPrivate</span><span class="p">(</span><span class="n">KPluginMetaData</span><span class="p">(),</span> <span class="n">args</span><span class="p">.</span><span class="n">count</span><span class="p">()</span> <span style="color: #aa2211">></span> <span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span> <span style="color: #aa2211">?</span> <span class="n">args</span><span class="p">[<span class="bright"></span></span><span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span><span class="p">].</span><span class="n">toInt</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">       <span class="n">d</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">AppletPrivate</span><span class="p">(</span><span class="n">KPluginMetaData</span><span class="p">(),</span> <span class="n">args</span><span class="p">.</span><span class="n">count</span><span class="p">()</span> <span style="color: #aa2211">></span> <span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span> <span style="color: #aa2211">?</span> <span class="n">args</span><span class="p">[<span class="bright"></span></span><span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span><span class="p">].</span><span class="n">toInt</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If anyone uses the old argument list syntax (where the first argument was a string or a kpluginmetadata)  this will break.</p>

<p style="padding: 0; margin: 8px;">Can we be sure that the PluginLoader was the only user? <br />
It was a somewhat undocumented thing right?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9123" rel="noreferrer">https://phabricator.kde.org/D9123</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>