<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9113" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Please push as two separate things.</p>

<p>The applet part looks fine aside from docs.</p>

<hr class="remarkup-hr" />

<p>UrlInterceptor.</p>

<p>IMHO it might be worth a release that continues onwards after the reg exp (so less performance benefits)  and prints a warning if we end up in the relativePath code?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9113#inline-41094" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">applet.h:109</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">explicit</span> <span style="color: #004012">Applet</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KPackage</span><span style="color: #aa2211">::</span><span class="n">Package</span> <span style="color: #aa2211">&</span><span class="n">package</span><span class="p">,</span> <span class="n">QObject</span> <span style="color: #aa2211">*</span><span class="n">parent</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QVariantList</span> <span style="color: #aa2211">&</span><span class="n">args</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">docs</p>

<p style="padding: 0; margin: 8px;">especially as we have N almost identical ones.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9113#inline-41093" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">packageurlinterceptor.cpp:99</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">//qDebug() << "Intercepted URL:" << path << type;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">path</span><span class="p">.</span><span class="n">toString</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">QRegularExpression</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"ui/.*\.js"</span><span class="p">))))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QString</span> <span class="n">rewritten</span> <span style="color: #aa2211">=</span> <span class="n">path</span><span class="p">.</span><span class="n">toString</span><span class="p">().</span><span class="n">replace</span><span class="p">(</span><span class="n">QRegularExpression</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"ui/(.*)\.js"</span><span class="p">)),</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"code/</span><span style="color: #bb6622">\\</span><span style="color: #766510">1.js"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QRegularExpression(QStringLiteral   as QRegularExpression is going to construct a QString</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9113#inline-41097" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">packageurlinterceptor.cpp:100</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">path</span><span class="p">.</span><span class="n">toString</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">QRegularExpression</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"ui/.*\.js"</span><span class="p">))))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QString</span> <span class="n">rewritten</span> <span style="color: #aa2211">=</span> <span class="n">path</span><span class="p">.</span><span class="n">toString</span><span class="p">().</span><span class="n">replace</span><span class="p">(</span><span class="n">QRegularExpression</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"ui/(.*)\.js"</span><span class="p">)),</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"code/</span><span style="color: #bb6622">\\</span><span style="color: #766510">1.js"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span style="color: #004012">QUrl</span><span class="p">(</span><span class="n">rewritten</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does use of the "data" folder go through the URL interceptor</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9113#inline-41095" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">packageurlinterceptor.cpp:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span class="n">path</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I know you uploaded this so I could profile it,<br />
but if we return here we don't want the code below.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9113" rel="noreferrer">https://phabricator.kde.org/D9113</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, apol, plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>