<table><tr><td style="">mwolff updated this revision to Diff 22887.<br />mwolff edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-ua6yepx6jlfhaze/" rel="noreferrer">(Show Details)</a><br />mwolff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8598" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>remove TODOs</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>file which would not trigger a rowAdded signal.<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"><br />
<br />
Overall, I'm quite happy with this approach. It seems to be quite<br />
stable and requires minimal invasive changes only. That said, in<br />
the long term we could, and should, cleanup this code to move<br />
more of the visual representation into the Positioner. That is a big<br />
change though, due to the way the Positioner is currently written.<br />
Most notably, that one reacts on rowsAboutToBeInserted which makes<br />
it impossible to query for any data of the row that gets inserted...</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D8598?vs=22715&id=22887" rel="noreferrer">https://phabricator.kde.org/D8598?vs=22715&id=22887</a></div></div><br /><div><strong>BRANCH</strong><div><div>wip/lim-2</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8598" rel="noreferrer">https://phabricator.kde.org/D8598</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>containments/desktop/plugins/folder/foldermodel.cpp<br />
containments/desktop/plugins/folder/foldermodel.h</div></div></div><br /><div><strong>To: </strong>mwolff, hein, amantia<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>