<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8692" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8692#inline-39690" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GridView.qml:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">implicitWidth:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">min</span><span class="p">(</span><span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span style="color: #004012">cellWidth</span> <span style="color: #aa2211">*</span> <span style="color: #601200">2</span> <span style="color: #aa2211">+</span> <span style="color: #004012">scroll</span><span class="p">.</span><span style="color: #004012">scrollBarSpace</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="p">,</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">floor</span><span class="p">(</span><span style="color: #004012">view</span><span class="p">.</span><span style="color: #004012">availableWidth</span> <span style="color: #aa2211">/</span> <span style="color: #004012">cellWidth</span><span class="p">)</span> <span style="color: #aa2211">*</span> <span style="color: #004012">cellWidth</span> <span style="color: #aa2211">+</span> <span style="color: #004012">scroll</span><span class="p">.</span><span style="color: #004012">scrollBarSpace</span> <span style="color: #aa2211">+</span> <span style="color: #601200">4</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It never ever makes sense for an item's implicitSize to be based on the parent's current size.</p>

<p style="padding: 0; margin: 8px;">It's up to the parent to increase this item's actual width to be bigger than the implicitWidth</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8692#inline-39695" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">thememodel.cpp:305</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">bool</span> <span class="n">haveCursors</span> <span style="color: #aa2211">=</span> <span class="n">themeDir</span><span class="p">.</span><span class="n">exists</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"cursors"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">bool</span> <span class="n">haveCursors</span> <span style="color: #aa2211">=</span> <span class="n">themeDir</span><span class="p">.</span><span class="n">exists</span><span class="p">(</span><span style="color: #766510">"cursors"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why change these QStringLiterals? Is a rebase needed?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8692#inline-39694" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">thememodel.cpp:321</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">static</span> <span style="color: #aa4000">bool</span> <span class="n">isX11</span> <span style="color: #aa2211">=</span> <span class="n">QX11Info</span><span style="color: #aa2211">::</span><span class="n">isPlatformX11</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">isX11</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This seems unrelated, adn I'm not sure is right.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8692" rel="noreferrer">https://phabricator.kde.org/D8692</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, aspotashev, januz, ngraham, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>