<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8748" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>One minor comment (the third one), otherwise all good.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8748#inline-38506" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">connection.cpp:395</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">case</span> <span style="color: #a0a000">LIBINPUT_EVENT_TOUCH_DOWN</span><span class="p">:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#ifndef KWIN_BUILD_TESTING</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">TouchEvent</span> <span style="color: #aa2211">*</span><span class="n">te</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">TouchEvent</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">event</span><span class="p">.</span><span class="n">data</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">not that it's a problem, but why? <br />
You have screens mocked already.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8748#inline-38507" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">connection.cpp:397</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">TouchEvent</span> <span style="color: #aa2211">*</span><span class="n">te</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">TouchEvent</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">event</span><span class="p">.</span><span class="n">data</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">emit</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">touchDown</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">te</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">id</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">te</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">absolutePos</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">m_</span>size<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">te</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">time</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n">te</span><span style="color: #aa2211">-></span><span class="n">device</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="n">size<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">screens</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">size</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">te</span><span style="color: #aa2211">-></span><span class="n">device<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">screenId</span></span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span style="color: #004012">touchDown</span><span class="p">(</span><span class="n">te</span><span style="color: #aa2211">-></span><span class="n">id</span><span class="p">(),</span> <span class="n">screens</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">geometry</span><span class="p">(</span><span class="n">te</span><span style="color: #aa2211">-></span><span class="n">device</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">screenId</span><span class="p">()).</span><span class="n">topLeft</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">te</span><span style="color: #aa2211">-></span><span class="n">absolutePos</span><span class="p">(</span><span class="n">size</span><span class="p">),</span> <span class="n">te</span><span style="color: #aa2211">-></span><span class="n">time</span><span class="p">(),</span> <span class="n">te</span><span style="color: #aa2211">-></span><span class="n">device</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if you fetch the geometry here you'll get both the size and topLeft in an easier to read way.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8748#inline-38508" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">connection.cpp:488</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">Connection</span><span style="color: #aa2211">::</span><span class="n">updateScreens</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you're not updating in deviceAdded(), so hypothetically if one adds a touch screen at runtime, and plugs in the HDMI cable before the USB cable it won't have the right screen.</p>
<p style="padding: 0; margin: 8px;">You could put this method (and the screens changed connect) in Device as you're not doing anything with Connection in this method.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8748" rel="noreferrer">https://phabricator.kde.org/D8748</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: </strong>davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>