<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8627" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8627#inline-37765" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drm_output.cpp:109</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QPoint</span></span><span class="bright"> </span><span class="n"><span class="bright">p</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="p"><span class="bright">((</span></span><span class="bright"></span><span class="n"><span class="bright">globalPos</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="n"><span class="bright">m_globalPos</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">m_scale</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="n"><span class="bright">m_backend</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">softwareCursorHotspot</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">QMatrix4x4</span></span><span class="bright"> </span><span class="n"><span class="bright">matrix</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_orientation</span> <span style="color: #aa2211">==</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">InvertedLandscapeOrientation</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">matrix</span><span class="p">.</span><span class="n">translate</span><span class="p">(</span><span class="n">pixelSize</span><span class="p">().</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">/</span><span style="color: #601200">2</span><span class="p">,</span> <span class="n">pixelSize</span><span class="p">().</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">for all variants of scaled, rotated and differently positioned outputs.</p></blockquote>

<p style="padding: 0; margin: 8px;">"by all variants of rotated" do you mean just this one?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8627#inline-37764" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drm_output.cpp:116</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">matrix</span><span class="p">.</span><span class="n">translate</span><span class="p">(</span><span style="color: #aa2211">-</span><span class="n">m_globalPos</span><span class="p">.</span><span class="n">x</span><span class="p">(),</span> <span style="color: #aa2211">-</span><span class="n">m_globalPos</span><span class="p">.</span><span class="n">y</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QPoint</span> <span class="n">p</span> <span style="color: #aa2211">=</span> <span class="n">matrix</span><span class="p">.</span><span class="n">map</span><span class="p">(</span><span class="n">globalPos</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span class="n">m_backend</span><span style="color: #aa2211">-></span><span class="n">softwareCursorHotspot</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">drmModeMoveCursor</span><span class="p">(</span><span class="n">m_backend</span><span style="color: #aa2211">-></span><span class="n">fd</span><span class="p">(),</span> <span class="n">m_crtc</span><span style="color: #aa2211">-></span><span class="n">id</span><span class="p">(),</span> <span class="n">p</span><span class="p">.</span><span class="n">x</span><span class="p">(),</span> <span class="n">p</span><span class="p">.</span><span class="n">y</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm 95% sure you need to rotate your softwareCursorHotspot.</p>

<p style="padding: 0; margin: 8px;">It's something hard to see, becuase you'll only be off by a few px.</p>

<p style="padding: 0; margin: 8px;">The only reason I'm not scaling the offset is because we're not scaling the contents of the cursor planet (which is arguably wrong), you are rotating it.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8627" rel="noreferrer">https://phabricator.kde.org/D8627</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: </strong>davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>