<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1230" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D1230#159026" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D1230#159026</a>, <a href="https://phabricator.kde.org/p/Kanedias/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@Kanedias</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>On the other side PipeWire is pretty new and its documentation is nearly non-existent. I don't know if with PipeWire it really could work in the way I described above. Your current solution works right now. It might still be an idea if you are interested to check out if you could integrate your approach with PipeWire in the way I described above or something similar and if you could do this now or only after the current version version of your patches has landed.</p></blockquote>
<p>Why is PipeWire preferred solution for this?</p></div>
</blockquote>
<p>The prefered solution from my side is one that is to clients the same on every Wayland compositor, so that clients only have to write one new backend for Wayland and not n for n Wayland compositors. The other important compositor in real world at the moment besides KWin is GNOME's mutter. Since they already have a working solution using PipeWire we should try to align our one with their one if it is feasible.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>GNOME has to support EGLStreams which have no such thing as buffer management like GBM, they can't just do buffer fd passing.<br />
Martin said he's not interested in EGLStreams and this whole patchset was prepared in agreement with him.</p></blockquote>
<p>Neither am I interested in EGLStreams. This is also not about not using GBM. My sketched concept with the KDE Daemon would still use GBM buffers for passing data between KWin and the Daemon. Only afterwards the Daemon would stream the Gl texture to interested clients via PipeWire instead of using GBM.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Yes, adding additional copying would solve many things, but I guess it's out of scope for this patch.</p></blockquote>
<p>Not sure what you mean with additional copying. If you mean the Gl copy in the Daemon from my concept: As far as I've understood it with your current approach you need to do a Gl texture copy anyway in the KRfb backend (and probably in every other client using the protocol at the same time).</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I'll take a look at PipeWire in my spare time. Is there any rush? I'm under strong impression something is happening.</p></blockquote>
<p>Thank you. There is no rush and nothing is happening out of the orderly.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1230" rel="noreferrer">https://phabricator.kde.org/D1230</a></div></div><br /><div><strong>To: </strong>Kanedias, graesslin, davidedmundson, subdiff, KWin<br /><strong>Cc: </strong>subdiff, ngraham, alexeymin, aacid, kwin, KWin, davidedmundson, plasma-devel, bwowk, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br /></div>