<table><tr><td style="">broulik accepted this revision.<br />broulik added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8309" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8309#inline-35069" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">backtracegenerator.cpp:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">//they should always be null before entering this function.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">Q_ASSERT</span><span class="p">(</span><span class="n">m_proc</span> <span style="color: #aa2211">==</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">NULL</span></span> <span style="color: #aa2211">&&</span> <span class="n">m_temp</span> <span style="color: #aa2211">==</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">NULL</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Q_ASSERT</span><span class="p">(</span><span class="n">m_proc</span> <span style="color: #aa2211">==</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span> <span style="color: #aa2211">&&</span> <span class="n">m_temp</span> <span style="color: #aa2211">==</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">Q_ASSERT(!m_proc && !m_temp)</tt>?<br />
iirc Clang doesn't like comparisons to <tt style="background: #ebebeb; font-size: 13px;">nullptr</tt> very much (at least in <tt style="background: #ebebeb; font-size: 13px;">QCOMPARE</tt>) and I find it cleaner</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8309#inline-35070" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">crashedapplication.cpp:98</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">free</span><span class="p">(</span><span class="n">savedLocale</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLocal8Bit</span><span class="p">(</span><span class="n">name</span> <span style="color: #aa2211">!=</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">NULL</span></span> <span style="color: #aa2211">?</span> <span style="color: #a0a000">name</span> <span class="p">:</span> <span style="color: #766510">"Unknown"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLocal8Bit</span><span class="p">(</span><span class="n">name</span> <span style="color: #aa2211">!=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span> <span style="color: #aa2211">?</span> <span style="color: #a0a000">name</span> <span class="p">:</span> <span style="color: #766510">"Unknown"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#else</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">name ? name : "Unknown"</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8309#inline-35071" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drkonqi.cpp:83</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">static</span> <span class="n">DrKonqi</span> <span style="color: #aa2211">*</span><span class="n">drKonqiInstance</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">NULL</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">static</span> <span class="n">DrKonqi</span> <span style="color: #aa2211">*</span><span class="n">drKonqiInstance</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">drKonqiInstance</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">could be simplified to <tt style="background: #ebebeb; font-size: 13px;">static DrKonqi *drKonqiInstance = new DrKonqi();</tt> or even created on the stack and return address (just noticed, not what this patch is about obviously)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8309" rel="noreferrer">https://phabricator.kde.org/D8309</a></div></div><br /><div><strong>To: </strong>kfunk, sitter, broulik<br /><strong>Cc: </strong>broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>