<table><tr><td style="">fvogt created this revision.<br />fvogt added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8178" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>tools.js is supposed to support both KaStatsFavoritesModel (used for<br />
favorite applications) and SimpleFavoritesModel (used for system actions,<br />
like poweroff/reboot/logout). The latter did not work though, as tools.js<br />
unconditionally calls methods only present in KaStatsFavoritesModel.<br />
This commit makes KaStatsFavoritesModel API compatible to SimpleFavoritesModel<br />
and changes the relevant code in tools.js to support both.</p>
<p>Additionally, this syncs applets/kickoff/package/contents/code/tools.js again.</p>
<p>BUG: 385463</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Before this patch it wasn't possible to remove system actions from<br />
the favorites bar.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>Plasma/5.11</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8178" rel="noreferrer">https://phabricator.kde.org/D8178</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/kicker/package/contents/code/tools.js<br />
applets/kicker/plugin/kastatsfavoritesmodel.cpp<br />
applets/kickoff/package/contents/code/tools.js</div></div></div><br /><div><strong>To: </strong>fvogt, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>