<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8131" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8131#inline-34044" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Label.qml:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span style="color: #004012"><span class="bright">T2</span></span><span class="p">.</span><span style="color: #004012">Label</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">id: root</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">height:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">round</span><span class="p">(</span><span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">paintedHeight</span><span class="p">,</span> <span style="color: #004012">Units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1.6</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">verticalAlignment:</span> <span style="color: #004012">lineCount</span> <span style="color: #aa2211">></span> <span style="color: #601200">1</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">Text.AlignTop :</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">AlignVCenter</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">activeFocusOnTab:</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">renderType:</span> <span style="color: #004012">Settings</span><span class="p">.</span><span style="color: #004012">isMobile</span> <span style="color: #aa2211">||</span> <span style="color: #004012">Window</span><span class="p">.</span><span style="color: #004012">devicePixelRatio</span> <span style="color: #aa2211">%</span> <span style="color: #601200">2</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">0</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">Text.QtRendering :</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">NativeRendering</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">font.capitalization:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">defaultFont</span><span class="p">.</span><span style="color: #004012">capitalization</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">font.family:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">defaultFont</span><span class="p">.</span><span style="color: #004012">family</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">font.italic:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">defaultFont</span><span class="p">.</span><span style="color: #004012">italic</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">font.letterSpacing:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">defaultFont</span><span class="p">.</span><span style="color: #004012">letterSpacing</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">font.pointSize:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">defaultFont</span><span class="p">.</span><span style="color: #004012">pointSize</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">font.strikeout:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">defaultFont</span><span class="p">.</span><span style="color: #004012">strikeout</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">font.underline:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">defaultFont</span><span class="p">.</span><span style="color: #004012">underline</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">font.weight:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">defaultFont</span><span class="p">.</span><span style="color: #004012">weight</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">font.wordSpacing:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">defaultFont</span><span class="p">.</span><span style="color: #004012">wordSpacing</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">textColor</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">opacity:</span> <span style="color: #004012">enabled</span><span style="color: #aa2211">?</span> <span style="color: #601200">1</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0.6</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">Accessible.role:</span> <span style="color: #004012">Accessible</span><span class="p">.</span><span style="color: #004012">StaticText</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">Accessible.name:</span> <span style="color: #004012">text</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #004012"><span class="bright">Controls</span></span><span class="p">.</span><span style="color: #004012">Label</span> <span class="p">{<span class="bright">}</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">in order to make it very explicit that's deprecated, i would like a print in component.oncompleted warning not to use it</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8131" rel="noreferrer">https://phabricator.kde.org/D8131</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, hein<br /></div>