<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7941" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>This is set to be a framework.<br />
We can't have a framework that imports something from workspace.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7941#inline-32996" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Label.qml:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">height:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">round</span><span class="p">(</span><span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">paintedHeight</span><span class="p">,</span> <span class="bright"></span><span style="color: #004012"><span class="bright">StylePrivate</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">TextSingleton</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">height</span></span> <span style="color: #aa2211">*</span> <span style="color: #601200">1.6</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">height:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">round</span><span class="p">(</span><span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">paintedHeight</span><span class="p">,</span> <span class="bright"></span><span style="color: #004012"><span class="bright">Kirigami</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">Units</span></span> <span style="color: #aa2211">*</span> <span style="color: #601200">1.6</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">verticalAlignment:</span> <span style="color: #004012">lineCount</span> <span style="color: #aa2211">></span> <span style="color: #601200">1</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">Text.AlignTop :</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">AlignVCenter</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This change is unrelated. <br />
Also I said in a review about how we shouldn't be doing this.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7941#inline-32998" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kquickstyleitem.cpp:167</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">Q_ASSERT</span><span class="p">(</span><span class="n">m_theme</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">m_theme</span><span style="color: #aa2211">-></span><span class="n">setInherit</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't understand what this is doing? It looks wrong?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7941#inline-32997" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kquickstyleitem.cpp:709</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_styleoption</span><span style="color: #aa2211">-></span><span class="n">palette</span> <span style="color: #aa2211">=</span> <span class="n">QApplication</span><span style="color: #aa2211">::</span><span class="n">palette</span><span class="p">(</span><span class="n">classNameForItem</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>m_styleoption->palette = QApplication::palette(classNameForItem());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">//m_theme->setColorSet(Kirigami::PlatformTheme::Complementary);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This area needs some tidying.</p>

<p style="padding: 0; margin: 8px;">Also we need this line if the palette isn't explicitly set to something else.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7941" rel="noreferrer">https://phabricator.kde.org/D7941</a></div></div><br /><div><strong>To: </strong>mart, Plasma, Kirigami, hein<br /><strong>Cc: </strong>davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>