<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson added a reviewer: Plasma.<br />Restricted Application added projects: Plasma on Wayland, Frameworks.<br />Restricted Application added subscribers: Frameworks, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7898" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>I don't understand the original logic.<br />
s_allResources contains /every/ resource, not just outputconfigurations.</p>
<p>Sending org_kde_kwin_outputconfiguration_send_applied to a wl_surface (for example),<br />
results in an error.</p>
<p>The reason kwin doesn't currently crash is because we don't actually send<br />
applied/failed after setting outputs. (which is another bug)</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>The existing unit test still passes.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7898" rel="noreferrer">https://phabricator.kde.org/D7898</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/server/outputconfiguration_interface.cpp</div></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, Frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br /></div>