<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7716" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7716#inline-31703" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span style="color: #4b4d51; font-weight: bold;">sddmauthhelper.cpp:228</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I just realized we have something similar in samba-mounter for the exact same reason:<br />
<a href="https://cgit.kde.org/samba-mounter.git/tree/src/helper/sambahelper.cpp#n49" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/samba-mounter.git/tree/src/helper/sambahelper.cpp#n49</a></p>
<p style="padding: 0; margin: 8px;">In this case we're forwarding the LANG from the user: in the end it's what the user requested not something specific to UTF-8. Nobody is enforcing paths to be utf8 AFAIK.</p>
<p style="padding: 0; margin: 8px;">I wonder if we could come up with a generic solution...</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">in my case I need to change the locale of my helper, not just subprocesses, which means I need to set it before I extract args from the user.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R123 SDDM Configuration Panel (KCM)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7716" rel="noreferrer">https://phabricator.kde.org/D7716</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>