<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7482" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7482#inline-30600" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">generator.cpp:553</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">//you'd find in a high res screen</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">dpi</span> <span style="color: #aa2211">></span> <span style="color: #601200">96</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1.5</span> <span style="color: #aa2211">&&</span> <span class="n">mode</span><span style="color: #aa2211">-></span><span class="n">size</span><span class="p">().</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">></span> <span style="color: #601200">1200</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1.5</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span style="color: #601200">2.0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">My laptop has 230dpi but only a vertical resolution of 1440, so this wouldn't work for me.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7482#inline-30601" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">generator.h:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">KScreen</span><span style="color: #aa2211">::</span><span class="n">ModePtr</span> <span class="n">bestModeForOutput</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KScreen</span><span style="color: #aa2211">::</span><span class="n">OutputPtr</span> <span style="color: #aa2211">&</span><span class="n">output</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">qreal</span> <span style="color: #004012">bestScaleForOutput</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KScreen</span><span style="color: #aa2211">::</span><span class="n">OutputPtr</span> <span style="color: #aa2211">&</span><span class="n">output</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7482" rel="noreferrer">https://phabricator.kde.org/D7482</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>