<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7260" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I get that there's a bug - I'm not remotely suggesting we drop the issue.<br />
Your supplied test is really useful, it's valid and I do want to see this problem get fixed.</p>
<p>But, we can't knowingly replace one bug with a different one, we don't improve anything. The old implementation is buggy in other ways.</p>
<p>Try adding this patch, add the appmenubar widget, run the test app in the libdbusmenuqt folder and click "Menu C". <br />
With this patch you can't open that menu at all.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Current code never obtains new submenus and always shows old ones.</p></blockquote>
<p>That's not entirely true. We do show the cached version, but also immediately call aboutToShow which will update the subtree. In theory at least :)</p>
<hr class="remarkup-hr" />
<p>I /think/ all we need to do is make sure the else branch of the old code handle reparenting? <br />
If you can have another look at that, that'd be great, otherwise I'll try later this week.</p>
<hr class="remarkup-hr" />
<p>Note also that the client code will go in one of two differnet paths depending on whether it's going through the plasma platform theme or not.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7260" rel="noreferrer">https://phabricator.kde.org/D7260</a></div></div><br /><div><strong>To: </strong>i.Dark_Templar, Plasma, davidedmundson<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>