<table><tr><td style="">sebas added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7256" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Some coding style suggestions</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7256#inline-29942" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notificationsengine.cpp:87</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">KIdleTime</span><span style="color: #aa2211">::</span><span class="n">instance</span><span class="p">(),</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span style="color: #aa4000">void</span> <span class="p">(</span><span class="n">KIdleTime</span><span style="color: #aa2211">::*</span><span class="p">)(</span><span style="color: #aa4000">int</span><span class="p">)</span><span style="color: #aa2211">></span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">KIdleTime</span><span style="color: #aa2211">::</span><span class="n">timeoutReached</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">idleId</span><span class="p">](</span><span style="color: #aa4000">int</span> <span class="n">id</span><span class="p">){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">id</span> <span style="color: #aa2211">==</span> <span class="n">idleId</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">m_history</span><span class="p">.</span><span class="n">clear</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">braces around the if block, please, space after if</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7256#inline-29941" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notificationsengine.cpp:401</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">NotificationData</span><span style="color: #aa2211">&</span> <span style="color: #a0a000">d</span> <span class="p">:</span> <span class="n">m_history</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">Notify</span><span class="p">(</span><span class="n">d</span><span class="p">.</span><span class="n">appName</span><span class="p">,</span> <span class="n">d</span><span class="p">.</span><span class="n">id</span><span class="p">,</span> <span class="n">d</span><span class="p">.</span><span class="n">appIcon</span><span class="p">,</span> <span class="n">d</span><span class="p">.</span><span class="n">summary</span><span class="p">,</span> <span class="n">d</span><span class="p">.</span><span class="n">body</span><span class="p">,</span> <span class="n">d</span><span class="p">.</span><span class="n">actions</span><span class="p">,</span> <span class="n">d</span><span class="p">.</span><span class="n">hints</span><span class="p">,</span> <span class="n">d</span><span class="p">.</span><span class="n">timeout</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">for (<br />
(missing whitespace)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7256" rel="noreferrer">https://phabricator.kde.org/D7256</a></div></div><br /><div><strong>To: </strong>progwolff, Plasma, mart<br /><strong>Cc: </strong>sebas, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, lukas<br /></div>