<table><tr><td style="">ltoscano added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6469" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>... and few in-line questions for the reviewers.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6469#inline-26665" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">autostart.cpp:75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KAboutData</span><span style="color: #aa2211">*</span> <span class="n">about</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KAboutData</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Autostart"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">KDE</span> Autostart Manager"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Session</span> Autostart Manager"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"1.0"</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Should this be "Session" or "Plasma Session"? Aren't the settings changed here valid for all desktops which follow the XDG spec?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6469#inline-26666" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">globalpaths.cpp:127</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #766510">" links to applications (shortcuts) that you want to have started"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #766510">" automatically whenever <span class="bright">KDE</span> starts. You can change the location of this"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">" automatically whenever <span class="bright">the Plasma session</span> starts. You can change the location of this"</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #766510">" folder if you want to, and the contents will move automatically"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I explicitly wrote "Plasma" because this setting seems to be Plasma-specific. Did I understand it correctly?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6469#inline-26667" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fonts.cpp:680</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #766510">" value a better option is explicitly configuring it for the whole X server if"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #766510">" possible (e.g. DisplaySize in xorg.conf<span class="bright"> or adding <i>-dpi value</i> to</span>"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #766510">" ServerLocalArgs= in $KDEDIR/share/config/kdm/kdmrc). When fonts do not render"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">" possible (e.g. DisplaySize in xorg.conf<span class="bright">). When fonts do not render</span>"</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #766510">" properly with real DPI value better fonts should be used or configuration"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Remove references to kdmrc in the meantime.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6469" rel="noreferrer">https://phabricator.kde.org/D6469</a></div></div><br /><div><strong>To: </strong>ltoscano<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>