<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6216" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6216#inline-25883" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationItem.qml:33</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">width:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">width</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">implicitHeight:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">appIconItem</span><span class="p">.</span><span style="color: #004012">v<span class="bright">isible</span></span> <span style="color: #aa2211">||</span> <span style="color: #004012">imageItem</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">units.iconSizes.large :</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">mainLayout</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">implicitHeight:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">appIconItem</span><span class="p">.</span><span style="color: #004012">v<span class="bright">alid</span></span> <span style="color: #aa2211">||</span> <span style="color: #004012">imageItem</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">nativeWidth</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">units.iconSizes.large :</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">mainLayout</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If in <a href="https://phabricator.kde.org/D6215" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D6215</a> you've got a mainItem->setVisible() before the showEvent because that fixes what this is doing.</p>
<p style="padding: 0; margin: 8px;">If that's the case, why do we still need these changes?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6216#inline-25881" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationPopup.qml:60</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// notification.actions is a JS array, but we can easily append that to our model</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">notificationItem</span><span class="p">.</span><span style="color: #004012">actions</span><span class="p">.</span><span style="color: #004012">clear</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">notificationItem</span><span class="p">.</span><span style="color: #004012">actions</span><span class="p">.</span><span style="color: #004012">append</span><span class="p">(</span><span style="color: #004012">notificationProperties</span><span class="p">.</span><span style="color: #004012">actions</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">So instead of making this inhibitor and changing a bunch of code</p>
<p style="padding: 0; margin: 8px;">just convert:</p>
<p style="padding: 0; margin: 8px;">list.clear()<br />
list.append()</p>
<p style="padding: 0; margin: 8px;">into:</p>
<p style="padding: 0; margin: 8px;">list = otherList</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6216" rel="noreferrer">https://phabricator.kde.org/D6216</a></div></div><br /><div><strong>To: </strong>mart, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>