<table><tr><td style="">Zren added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6188" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6188#inline-25446" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">anthonyfieroni</span> wrote in <span style="color: #4b4d51; font-weight: bold;">FolderView.qml:538</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Why it used (6 * units.smallSpacing) it makes more space at bottom? It should be same as iconwidth calculation, about me. I see you not change it, but it should.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Fairly certain was <tt style="background: #ebebeb; font-size: 13px;">smallSpacing * 2</tt> + <tt style="background: #ebebeb; font-size: 13px;">iconSize</tt> + <tt style="background: #ebebeb; font-size: 13px;">smallSpacing * 2</tt> + <tt style="background: #ebebeb; font-size: 13px;">defaultFont.height * lines</tt> + <tt style="background: #ebebeb; font-size: 13px;">smallSpacing * 2</tt></p>
<p style="padding: 0; margin: 8px;">Right now:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">frame</tt> has <tt style="background: #ebebeb; font-size: 13px;">y: root.useListViewMode ? 0 : units.smallSpacing</tt></li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">frame</tt> has <tt style="background: #ebebeb; font-size: 13px;">height: (icon.height + (2 * units.smallSpacing) + (label.lineCount * theme.mSize(theme.defaultFont).height) + (3 * units.smallSpacing));</tt></li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">icon</tt> has <tt style="background: #ebebeb; font-size: 13px;">topMargin: (2 * units.smallSpacing)</tt></li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">label</tt> has <tt style="background: #ebebeb; font-size: 13px;">anchors.topMargin: units.smallSpacing</tt></li>
</ul>
<p style="padding: 0; margin: 8px;">So it's actually:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">smallSpacing | frame | smallSpacing*2 | icon | smallSpacing | text | smallSpacing*2</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6188" rel="noreferrer">https://phabricator.kde.org/D6188</a></div></div><br /><div><strong>To: </strong>Zren, hein<br /><strong>Cc: </strong>anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>