<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5928" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5928#111282" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D5928#111282</a>, <a href="https://phabricator.kde.org/p/graesslin/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I wouldn't call it color correction as we used to have a mechanism called color correction in the past which did something very different. Personal suggestion: gamma correction or color temperature correction.</p></div>
</blockquote>
<p>I have looked it up now and it's something about ICC profiles for screens. Is this stuff functionally right now in KWin? Don't forget that Night Color is only the first part of the planned work here. In the end it is also about giving the user control over gamma / color values of the attached screens in general, which sounds similar to the ICC profiles stuff and maybe should be integrated anyway. Which means then it would make sense again to use the proposed name. But if not, gamma correction would be the way to go, because as I said in the end not only color temperature</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Sorry cannot do a full review for the next few weeks.</p></blockquote>
<p>No problem, we have lots of time till next release. :)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Personally I do not mind whether the functionality is in KWin or extern. The argument of first frane after suspend is a good one. I didn't check the code in detail so ignote if it doesn't matter: in long term I want to forbid KWin to have Internet access. So the geolocation neefs to happen outside of KWin.</p></blockquote>
<p>Geolocation is outside (in Plasma Workspace). No internet access needed from within KWin.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>And congrats for top item on r/linux :-P</p></blockquote>
<p>At least we now can be sure, that there is general interest for such a feature.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5928" rel="noreferrer">https://phabricator.kde.org/D5928</a></div></div><br /><div><strong>To: </strong>subdiff, KWin<br /><strong>Cc: </strong>graesslin, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas<br /></div>