<table><tr><td style="">lueck added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5932" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5932#inline-24300" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">subdiff</span> wrote in <span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:2</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Ah, that's what these mysterious Messages.sh files everywhere are for. ;)</p>
<p style="padding: 0; margin: 8px;">Is the Messages.sh right this way?</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="bash" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="ch">#! /usr/bin/env bash</span>
$XGETTEXT <span style="color: #766510">`</span>find . -name <span style="color: #766510">"*.qml"</span><span style="color: #766510">`</span> -o $podir/kcm_nightcolor.pot</pre></div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You need to add "*.cpp", see my comment in kcm.cpp</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5932#inline-24438" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm.cpp:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"0.1"</span><span class="p">),</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">KAboutLicense</span><span style="color: #aa2211">::</span><span class="n">LGPL</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">about</span><span style="color: #aa2211">-></span><span class="n">addAuthor</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Roman Gilg"</span><span class="p">),</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"subdiff@gmail.com"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setAboutData</span><span class="p">(</span><span class="n">about</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">i18n () calls missing, see <a href="https://websvn.kde.org/trunk/l10n-kf5/sr/messages/kde-workspace/kcm_touchpad.po?revision=1485125&view=markup" class="remarkup-link" target="_blank" rel="noreferrer">https://websvn.kde.org/trunk/l10n-kf5/sr/messages/kde-workspace/kcm_touchpad.po?revision=1485125&view=markup</a> line 75</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5932#inline-24436" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm.cpp:34</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setAboutData</span><span class="p">(</span><span class="n">about</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setButtons</span><span class="p">(</span><span class="n">Help</span> <span style="color: #aa2211">|</span> <span class="n">Apply</span> <span style="color: #aa2211">|</span> <span class="n">Default</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Using the button Help does not make sense without a docbook and whithout an entry X-DocPath in the desktop file</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5932#inline-24439" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LocationsAutoView.qml:28</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Controls</span><span class="p">.</span><span style="color: #004012">Label</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">i18nd</span><span class="p">(</span><span style="color: #766510">"kcm_nightcolor"</span><span class="p">,</span> <span style="color: #766510">"Latitude"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.alignment:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">AlignRight</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">in CMakelists.txt you set the domain already to "kcm_nightcolor", therefore the i18nd call should be replaced by i18n() calls<br />
that is less error prone if a catalogs has to be renamed.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5932" rel="noreferrer">https://phabricator.kde.org/D5932</a></div></div><br /><div><strong>To: </strong>subdiff, Plasma<br /><strong>Cc: </strong>lueck, mart, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>