<table><tr><td style="">subdiff updated this revision to Diff 14753.<br />subdiff marked 4 inline comments as done.<br />subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5932" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Diff update:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Fixed inline comments</li>
<li class="remarkup-list-item">Fixed <a href="https://phabricator.kde.org/p/mart/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@mart</a>'s comment</li>
<li class="remarkup-list-item">Labels aligned to the right</li>
<li class="remarkup-list-item">Slight renaming of labels ("Sunrise/set ends" -> "and ends")</li>
</ul>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Make sure you test with --reverse, I think your activator checkbox will be broken</p></blockquote>

<p>You're right, but I'm just using the text attribute of QQC's CheckBox, so I'm not sure if I should write a workaround here or just wait for upstream to fix it. The visual fallout is minimal and the checkbox still usable:<br />
<a href="https://phabricator.kde.org/F3760241" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F3760241: Rw1t2w7 - Imgur.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D5932?vs=14747&id=14753" rel="noreferrer">https://phabricator.kde.org/D5932?vs=14747&id=14753</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5932" rel="noreferrer">https://phabricator.kde.org/D5932</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
kcms/CMakeLists.txt<br />
kcms/nightcolor/CMakeLists.txt<br />
kcms/nightcolor/kcm.cpp<br />
kcms/nightcolor/kcm.h<br />
kcms/nightcolor/kcm_nightcolor.desktop<br />
kcms/nightcolor/package/contents/ui/LocationsAutoView.qml<br />
kcms/nightcolor/package/contents/ui/LocationsFixedView.qml<br />
kcms/nightcolor/package/contents/ui/NumberField.qml<br />
kcms/nightcolor/package/contents/ui/TimeField.qml<br />
kcms/nightcolor/package/contents/ui/TimingsView.qml<br />
kcms/nightcolor/package/contents/ui/main.qml<br />
kcms/nightcolor/package/metadata.desktop</div></div></div><br /><div><strong>To: </strong>subdiff, Plasma<br /><strong>Cc: </strong>mart, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>