<table><tr><td style="">subdiff created this revision.<br />subdiff added projects: Plasma on Wayland, KWin.<br />Restricted Application edited projects, added Plasma; removed KWin, Plasma on Wayland.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5931" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><h3 class="remarkup-header">Introduction</h3>
<p>With <a href="https://phabricator.kde.org/D5928" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D5928</a> I've introduced Night Color in KWin. It was designed in a way to be fully configurable (while safe checking values) via DBus. Also it is supposed to get updated location data from workspace. To ease the configuration and provide the updated location data this library was written.</p>
<h3 class="remarkup-header">Features</h3>
<ul class="remarkup-list">
<li class="remarkup-list-item">Abstracts away the DBus part and provides a generic adaptor to the compositor as QML object for that<ul class="remarkup-list">
<li class="remarkup-list-item">Allows to stage values and send them at once as needed for KWin's atomic config changes</li>
<li class="remarkup-list-item">Informs about configuration changes</li>
</ul></li>
<li class="remarkup-list-item">Provides also QML objects for other often used functionality in this context (sun calculator and a locator, i.e. an encapsulated connection to the location data service).</li>
<li class="remarkup-list-item">For automatic location updates the library provides a KDE Daemon Module, which gets the current location via such a locator object and sends it to KWin.</li>
<li class="remarkup-list-item">The library is named and structured in a way, such that it later can be extended with functionality to configure gamma values in general (normal color correction), i.e. as soon as the support for that has landed in KWin.</li>
</ul>
<p>In theory the library could be used with other compositors as well, if they use a somewhat similar mechanism as KWin. In this case though the CompositorAdaptor class would need to be rewritten in parts, probably subclassed. A KCM in Plasma Desktop, which uses this library to configure KWin, is already written and its Diff will be uploaded soon.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Manually and auto tests.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5931" rel="noreferrer">https://phabricator.kde.org/D5931</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
libcolorcorrect/CMakeLists.txt<br />
libcolorcorrect/LibColorCorrectConfig.cmake.in<br />
libcolorcorrect/README<br />
libcolorcorrect/autotests/CMakeLists.txt<br />
libcolorcorrect/autotests/mock_kwin.cpp<br />
libcolorcorrect/autotests/mock_kwin.h<br />
libcolorcorrect/autotests/nightcolortest.cpp<br />
libcolorcorrect/autotests/qtest_dbus.h<br />
libcolorcorrect/colorcorrectconstants.h<br />
libcolorcorrect/compositorcoloradaptor.cpp<br />
libcolorcorrect/compositorcoloradaptor.h<br />
libcolorcorrect/declarative/CMakeLists.txt<br />
libcolorcorrect/declarative/colorcorrectplugin.cpp<br />
libcolorcorrect/declarative/colorcorrectplugin.h<br />
libcolorcorrect/declarative/qmldir<br />
libcolorcorrect/geolocator.cpp<br />
libcolorcorrect/geolocator.h<br />
libcolorcorrect/kded/CMakeLists.txt<br />
libcolorcorrect/kded/colorcorrectlocationupdater.desktop<br />
libcolorcorrect/kded/locationupdater.cpp<br />
libcolorcorrect/kded/locationupdater.h<br />
libcolorcorrect/suncalc.cpp<br />
libcolorcorrect/suncalc.h</div></div></div><br /><div><strong>To: </strong>subdiff, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>