<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5538" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Please fix the style issues.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5538#inline-23426" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdeplatformtheme.cpp:124-125</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#if QT_VERSION < QT_VERSION_CHECK(5, 8, 0)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QPixmap</span> <span class="n">KdePlatformTheme</span><span style="color: #aa2211">::</span><span class="n">fileIconPixmap</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QFileInfo</span> <span style="color: #aa2211">&</span><span class="n">fileInfo</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QSizeF</span> <span style="color: #aa2211">&</span><span class="n">size</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPlatformTheme</span><span style="color: #aa2211">::</span><span class="n">IconOptions</span> <span class="n">iconOptions</span><span class="p">)</span> <span style="color: #aa4000">const</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please either use indentation or use a single line</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5538#inline-23425" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdeplatformtheme.h:48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QIcon</span> <span style="color: #004012">fileIcon</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QFileInfo</span> <span style="color: #aa2211">&</span><span class="n">fileInfo</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPlatformTheme</span><span style="color: #aa2211">::</span><span class="n">IconOptions</span> <span class="n">iconOptions</span><span class="p">)</span> <span style="color: #aa4000">const</span> <span class="n">Q_DECL_OVERRIDE</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#else</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please use override instead of Q_DECL_OVERRIDE</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5538#inline-23424" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdeplatformtheme.h:71</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QScopedPointer</span><span style="color: #aa2211"><</span><span class="n">X11Integration</span><span style="color: #aa2211">></span> <span class="n">m_x11Integration</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">nitpick: unrelated removal of empty line</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5538" rel="noreferrer">https://phabricator.kde.org/D5538</a></div></div><br /><div><strong>To: </strong>eshalygin, Plasma, markg, graesslin<br /><strong>Cc: </strong>graesslin, ltoscano, broulik, markg, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>