<table><tr><td style="">markg accepted this revision.<br />markg added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5670" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5670#inline-23150" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statusnotifieritemsource.cpp:393-399</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">QSysInfo</span><span style="color: #aa2211">::</span><span class="n">ByteOrder</span> <span style="color: #aa2211">==</span> <span class="n">QSysInfo</span><span style="color: #aa2211">::</span><span class="n">LittleEndian</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">uint</span> <span style="color: #aa2211">*</span><span class="n">uintBuf</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">uint</span> <span style="color: #aa2211">*</span><span class="p">)</span> <span class="n">image</span><span class="p">.</span><span class="n">data</span><span class="p">.</span><span class="n">data</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">uint</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span class="n">i</span> <span style="color: #aa2211"><</span> <span class="n">image</span><span class="p">.</span><span class="n">data</span><span class="p">.</span><span class="n">size</span><span class="p">()</span><span style="color: #aa2211">/</span><span style="color: #aa4000">sizeof</span><span class="p">(</span><span class="n">uint</span><span class="p">);</span> <span style="color: #aa2211">++</span><span class="n">i</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa2211">*</span><span class="n">uintBuf</span> <span style="color: #aa2211">=</span> <span class="n">ntohl</span><span class="p">(</span><span style="color: #aa2211">*</span><span class="n">uintBuf</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa2211">++</span><span class="n">uintBuf</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated to your commit, i know.</p>

<p style="padding: 0; margin: 8px;">Is there a reason why this is done at runtime?</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">#if Q_BYTE_ORDER == Q_LITTLE_ENDIAN
// convert.. with qFromLittleEndian for instance
#endif</pre></div>

<p style="padding: 0; margin: 8px;">Just curious.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5670#inline-23151" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">statusnotifieritemsource.cpp:409</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QImage</span> <span style="color: #004012">iconImage</span><span class="p">((</span><span style="color: #aa4000">const</span> <span class="n">uchar</span><span style="color: #aa2211">*</span><span class="p">)</span><span class="n">dataRef</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">(),</span> <span class="n">image</span><span class="p">.</span><span class="n">width</span><span class="p">,</span> <span class="n">image</span><span class="p">.</span><span class="n">height</span><span class="p">,</span> <span class="n">QImage</span><span style="color: #aa2211">::</span><span class="n">Format_ARGB32</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">[](</span><span style="color: #aa4000">void</span><span style="color: #aa2211">*</span> <span class="n">ptr</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Very smart! I didn't even know that was possible.<br />
The cast should change to a C++ style cast though.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5670" rel="noreferrer">https://phabricator.kde.org/D5670</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma, markg<br /><strong>Cc: </strong>markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>