<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5490" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Cool, seems like a solid approach.</p>

<p>Just nitpicks left.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5490#inline-22829" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mousehelper.h:41-42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Q_INVOKABLE</span> <span class="n">QPointF</span> <span style="color: #004012">globalMousePosition</span><span class="p">()</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Q_INVOKABLE</span> <span style="color: #aa4000">void</span> <span style="color: #004012">setGlobalMousePosition</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QPointF</span> <span style="color: #aa2211">&</span><span class="n">pos</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You don't need these to be invokable if you're exposing them as a property.</p>

<p style="padding: 0; margin: 8px;">Right now you're exporting two things with the same name, the value of a property and a function.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5490#inline-22828" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">qmlplugins.cpp:41</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">qmlRegisterType</span><span style="color: #aa2211"><</span><span class="n">Milou</span><span style="color: #aa2211">::</span><span class="n">DragHelper</span><span style="color: #aa2211">></span> <span class="p">(</span><span class="n">uri</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">2</span><span class="p">,</span> <span style="color: #766510">"DragHelper"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qmlRegisterType</span><span style="color: #aa2211"><</span><span class="n">Milou</span><span style="color: #aa2211">::</span><span class="n">MouseHelper</span><span style="color: #aa2211">></span> <span class="p">(</span><span class="n">uri</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">,</span> <span style="color: #766510">"MouseHelper"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">May as well register a singleton, it doesn't have a state.</p>

<p style="padding: 0; margin: 8px;">Instead of having one object created per delegate, we just one have object.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R112 Milou</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5490" rel="noreferrer">https://phabricator.kde.org/D5490</a></div></div><br /><div><strong>To: </strong>leszeklesner, broulik<br /><strong>Cc: </strong>ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>