<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5411" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5411#inline-22623" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">colorscm.cpp:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">schemeList</span><span style="color: #aa2211">-></span><span class="n">insertItem</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span class="n">currentitem</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">schemeList</span><span style="color: #aa2211">-></span><span class="n">blockSignals</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span> <span style="color: #74777d">// don't emit changed signals</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">schemeList</span><span style="color: #aa2211">-></span><span class="n">setCurrentItem</span><span class="p">(</span><span class="n">currentitem</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What is this about?<br />
blocking signals is a sign of something else being seriously wrong.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5411#inline-22626" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">colorscm.cpp:416</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">QListWidgetItem</span> <span style="color: #aa2211">*</span><span class="n">item</span> <span style="color: #aa2211">=</span> <span class="n">schemeList</span><span style="color: #aa2211">-></span><span class="n">item</span><span class="p">(</span><span class="n">i</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">item</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"Default color scheme"</span><span class="p">,</span> <span style="color: #766510">"Default"</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #74777d">// If editing the default scheme, force a reload, else select the default scheme</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Heh, there's some leftovers of the old code here.</p>

<p style="padding: 0; margin: 8px;">At least it makes adding this back easier :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5411#inline-22625" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">colorscm.cpp:447</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">//Default scheme</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">schemeList</span><span style="color: #aa2211">-></span><span class="n">currentRow</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">KSharedConfigPtr</span> <span class="n">config</span> <span style="color: #aa2211">=</span> <span class="n">m_config</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sometime's we're comparing the name to find out which is "default" sometimes using index.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5411#inline-22624" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">colorscm.cpp:458-459</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">dialog</span><span style="color: #aa2211">-></span><span class="n">show</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">connect</span><span class="p">(</span><span class="n">dialog</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">SchemeEditorDialog</span><span style="color: #aa2211">::</span><span class="n">accepted</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa2211">=</span><span class="p">](){</span> <span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">populateSchemeList</span><span class="p">();</span> <span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">connect</span><span class="p">(</span><span class="n">dialog</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">SchemeEditorDialog</span><span style="color: #aa2211">::</span><span class="n">rejected</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa2211">=</span><span class="p">](){</span> <span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">populateSchemeList</span><span class="p">();</span> <span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If the current design is for saving to be handled by signaling from the dialog to the KCM which does the actual saving. You should handle apply in the same way.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5411" rel="noreferrer">https://phabricator.kde.org/D5411</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>