<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5409" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5409#inline-22169" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KNSBackend.cpp:330</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">m_page</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">connect</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KNSBackend</span><span style="color: #aa2211">::</span><span class="n">receivedResources</span><span class="p">,</span> <span class="n">stream</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">ResultsStream</span><span style="color: #aa2211">::</span><span class="n">resourcesFound</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">connect</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KNSBackend</span><span style="color: #aa2211">::</span><span class="n">receivedResources</span><span class="p">,</span> <span class="n">stream</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">ResultsStream</span><span style="color: #aa2211">::</span><span class="n">resourcesFound<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">QueuedConnection</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">connect</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KNSBackend</span><span style="color: #aa2211">::</span><span class="n">searchFinished</span><span class="p">,</span> <span class="n">stream</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">ResultsStream</span><span style="color: #aa2211">::</span><span class="n">deleteLater</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Then maybe it's KNS that should be syncing?<br />
i.e. <tt style="background: #ebebeb; font-size: 13px;">connect(m_engine, &KNSCore::Engine::signalEntriesLoaded, this, &KNSBackend::receivedEntries);</tt></p>

<p style="padding: 0; margin: 8px;">Or even have KNSCore emit from the object's thread:<br />
<a href="http://doc.qt.io/qt-5/threads-qobject.html#signals-and-slots-across-threads" class="remarkup-link" target="_blank" rel="noreferrer">http://doc.qt.io/qt-5/threads-qobject.html#signals-and-slots-across-threads</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5409" rel="noreferrer">https://phabricator.kde.org/D5409</a></div></div><br /><div><strong>To: </strong>leinir, Discover Software Store, apol<br /><strong>Cc: </strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>