<table><tr><td style="">markg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5345" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I'm just curious. Why is the day name determined in QML (in the lines you edited, but was there before as well) and on the C++ side?<br />
It smells like a redundancy.</p>
<p>As far as i can tell (only looked for a moment), the dayName on the C++ side isn't used "in" the C++ side. It's sole purpose is to be used by QML.<br />
I'm fine with whatever you do though :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5345" rel="noreferrer">https://phabricator.kde.org/D5345</a></div></div><br /><div><strong>To: </strong>drosca, Plasma, mck182<br /><strong>Cc: </strong>markg, plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>