<table><tr><td style="">hein added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5243" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>review talk</p>
<p>[22:08] <Sho_> notmart: if you redefine a property with different NOTIFY signals, do the other signals from the baseclass still work, too?<br />
[22:09] <Sho_> notmart: also, why do you need different NOTIFY signals, can't you just emit the base class ones?<br />
[22:09] <notmart> Sho_: the implicitWidthChanged signal seen from qml side should become the new one if i'm right<br />
[22:09] --> s8321414 (~s8321414@150.117.137.90) has joined this channel.<br />
[22:10] <notmart> no, apparently i can't put a signal from the superclass in the q_property definition :/<br />
[22:10] <Sho_> hmm<br />
[22:10] <Sho_> so if the base class emits implicitWidthChanged, the prop still notifies, too?<br />
[22:10] <Sho_> or only on your implicitWidthChanged2?<br />
[22:10] <Sho_> because if it's the latter you need more connects<br />
[22:13] <notmart> hmm, i should test it a bit more i guess :/<br />
[22:13] <Sho_> unit tests<br />
[22:13] <Sho_> :-)<br />
[22:13] <notmart> i don't like that patch as redefining properties in c++ is a really messy thing<br />
[22:14] <Sho_> aye</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5243" rel="noreferrer">https://phabricator.kde.org/D5243</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>hein, davidedmundson, plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>