<table><tr><td style="">subdiff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3504" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3504#inline-21675" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">egl_gbm_backend.cpp:198</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qreal</span> <span class="n">scale</span> <span style="color: #aa2211">=</span> <span class="n">output</span><span class="p">.</span><span class="n">output</span><span style="color: #aa2211">-></span><span class="n">scale</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">glViewport</span><span class="p">(</span><span style="color: #aa2211">-</span><span class="n">v</span><span class="p">.</span><span class="n">x</span><span class="p">(),</span> <span class="n">v</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">overall</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">v</span><span class="p">.</span><span class="n">y</span><span class="p">(),</span> <span class="n">overall</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">scale</span><span class="p">,</span> <span class="n">overall</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">scale</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">return</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I still don't think this is the right way to use scale here. But it's currently not possible to test it with scale > 1, is it? I tried to use the <tt style="background: #ebebeb; font-size: 13px;">scale</tt> option from <a href="https://phabricator.kde.org/D3159" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D3159</a>, but <tt style="background: #ebebeb; font-size: 13px;">initialOutputScale</tt> is currently only available for X11WindowedBackend. Can you make the test option usable in the DRM backend as well? This won't test different scale factors on multiple monitors though.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3504" rel="noreferrer">https://phabricator.kde.org/D3504</a></div></div><br /><div><strong>To: </strong>davidedmundson, graesslin, Plasma<br /><strong>Cc: </strong>KWin, subdiff, graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>