<table><tr><td style="">jamesl created this revision.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5250" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Breeze ships with 24 and 48 px cursors, and recently added 36 px in<br />
<a href="https://phabricator.kde.org/D4358" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;" rel="noreferrer">D4358</a>. However, with modern screen resolutions coming in all over the<br />
place, there need to be more options. For example, my 14" WQHD display<br />
with a scaling factor of 1.67 looks best with a (24 * 1.67 =) 40 px<br />
cursor. Beyond that, 6k and 8k displays are not far off. KDE already<br />
supports a 3X scaling mode, but doesn't come with a cursor size suitable<br />
for it. GNOME's Adwaita theme already supports 24, 32, 48, 64, and 96<br />
px cursor options. Breeze should have at least the same options.</p>
<p>This change turns the xcursorgen config files into something that can<br />
be processed to generate arbitrary size cursors. The build script has<br />
been modified to iterate over a list of sizes that can be changed as<br />
desired without having to change any hardcoded values. Pointer x-y<br />
hit values are interpolated, and where they fall between pixels, they<br />
are rounded to the nearest pixel. This does not seem to affect<br />
usability, especially on the high-dpi displays for which the cursors<br />
are intended.</p>
<p>Please see Bug #363147 for additional commentary.</p>
<p><a href="https://bugs.kde.org/show_bug.cgi?id=363147" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=363147</a></p>
<div style="margin: 16px 0;
padding: 12px;
border-left: 3px solid #2980b9;
background: #daeaf3;"><span class="remarkup-note-word">NOTE:</span> This change causes all of the cursor bitmaps and binaries to be
regenerated. That was too large for Phabricator, so I have elimitated
them from this diff. If accepted, you must run the build.sh script in
the Breeze cursor directory to regenerate the binary cursors before
committing.</div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5250" rel="noreferrer">https://phabricator.kde.org/D5250</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>cursors/Breeze/Breeze/cursors/00000000000000020006000e7e9ffc3f<br />
cursors/Breeze/Breeze/cursors/00008160000006810000408080010102<br />
cursors/Breeze/Breeze/cursors/03b6e0fcb3499374a867c041f52298f0<br />
cursors/Breeze/Breeze/cursors/08e8e1c95fe2fc01f976f1e063a24ccd<br />
cursors/Breeze/Breeze/cursors/1081e37283d90000800003c07f3ef6bf<br />
cursors/Breeze/Breeze/cursors/3085a0e285430894940527032f8b26df<br />
cursors/Breeze/Breeze/cursors/3ecb610c1bf2410f44200f48c40d3599<br />
cursors/Breeze/Breeze/cursors/4498f0e0c1937ffe01fd06f973665830<br />
cursors/Breeze/Breeze/cursors/5c6cd98b3f3ebcb1f9c7f1c204630408<br />
cursors/Breeze/Breeze/cursors/6407b0e94181790501fd1e167b474872<br />
cursors/Breeze/Breeze/cursors/640fb0e74195791501fd1ed57b41487f<br />
cursors/Breeze/Breeze/cursors/9081237383d90e509aa00f00170e968f<br />
cursors/Breeze/Breeze/cursors/9d800788f1b08800ae810202380a0822<br />
cursors/Breeze/Breeze/cursors/a2a266d0498c3104214a47bd64ab0fc8<br />
cursors/Breeze/Breeze/cursors/alias<br />
cursors/Breeze/Breeze/cursors/all-scroll<br />
cursors/Breeze/Breeze/cursors/b66166c04f8c3109214a4fbd64a50fc8<br />
cursors/Breeze/Breeze/cursors/bottom_left_corner<br />
cursors/Breeze/Breeze/cursors/bottom_right_corner<br />
cursors/Breeze/Breeze/cursors/bottom_side<br />
cursors/Breeze/Breeze/cursors/cell<br />
cursors/Breeze/Breeze/cursors/center_ptr<br />
cursors/Breeze/Breeze/cursors/circle<br />
cursors/Breeze/Breeze/cursors/closedhand<br />
cursors/Breeze/Breeze/cursors/col-resize<br />
cursors/Breeze/Breeze/cursors/color-picker<br />
cursors/Breeze/Breeze/cursors/context-menu<br />
cursors/Breeze/Breeze/cursors/copy<br />
cursors/Breeze/Breeze/cursors/cross<br />
cursors/Breeze/Breeze/cursors/crossed_circle<br />
cursors/Breeze/Breeze/cursors/crosshair<br />
cursors/Breeze/Breeze/cursors/d9ce0ab605698f320427677b458ad60b<br />
cursors/Breeze/Breeze/cursors/default<br />
cursors/Breeze/Breeze/cursors/dnd-copy<br />
cursors/Breeze/Breeze/cursors/dnd-move<br />
cursors/Breeze/Breeze/cursors/dnd-no-drop<br />
cursors/Breeze/Breeze/cursors/dnd-none<br />
cursors/Breeze/Breeze/cursors/down-arrow<br />
cursors/Breeze/Breeze/cursors/draft<br />
cursors/Breeze/Breeze/cursors/e-resize<br />
cursors/Breeze/Breeze/cursors/e29285e634086352946a0e7090d73106<br />
cursors/Breeze/Breeze/cursors/fcf21c00b30f7e3f83fe0dfd12e71cff<br />
cursors/Breeze/Breeze/cursors/fleur<br />
cursors/Breeze/Breeze/cursors/forbidden<br />
cursors/Breeze/Breeze/cursors/h_double_arrow<br />
cursors/Breeze/Breeze/cursors/half-busy<br />
cursors/Breeze/Breeze/cursors/hand1<br />
cursors/Breeze/Breeze/cursors/hand2<br />
cursors/Breeze/Breeze/cursors/help<br />
cursors/Breeze/Breeze/cursors/ibeam<br />
cursors/Breeze/Breeze/cursors/left-arrow<br />
cursors/Breeze/Breeze/cursors/left_ptr<br />
cursors/Breeze/Breeze/cursors/left_ptr_help<br />
cursors/Breeze/Breeze/cursors/left_ptr_watch<br />
cursors/Breeze/Breeze/cursors/left_side<br />
cursors/Breeze/Breeze/cursors/link<br />
cursors/Breeze/Breeze/cursors/move<br />
cursors/Breeze/Breeze/cursors/n-resize<br />
cursors/Breeze/Breeze/cursors/no-drop<br />
cursors/Breeze/Breeze/cursors/not-allowed<br />
cursors/Breeze/Breeze/cursors/openhand<br />
cursors/Breeze/Breeze/cursors/pencil<br />
cursors/Breeze/Breeze/cursors/pirate<br />
cursors/Breeze/Breeze/cursors/plus<br />
cursors/Breeze/Breeze/cursors/pointer<br />
cursors/Breeze/Breeze/cursors/pointing_hand<br />
cursors/Breeze/Breeze/cursors/progress<br />
cursors/Breeze/Breeze/cursors/question_arrow<br />
cursors/Breeze/Breeze/cursors/right-arrow<br />
cursors/Breeze/Breeze/cursors/right_ptr<br />
cursors/Breeze/Breeze/cursors/right_side<br />
cursors/Breeze/Breeze/cursors/row-resize<br />
cursors/Breeze/Breeze/cursors/s-resize<br />
cursors/Breeze/Breeze/cursors/sb_h_double_arrow<br />
cursors/Breeze/Breeze/cursors/sb_v_double_arrow<br />
cursors/Breeze/Breeze/cursors/size-bdiag<br />
cursors/Breeze/Breeze/cursors/size-fdiag<br />
cursors/Breeze/Breeze/cursors/size-hor<br />
cursors/Breeze/Breeze/cursors/size-ver<br />
cursors/Breeze/Breeze/cursors/size_all<br />
cursors/Breeze/Breeze/cursors/size_bdiag<br />
cursors/Breeze/Breeze/cursors/size_fdiag<br />
cursors/Breeze/Breeze/cursors/size_hor<br />
cursors/Breeze/Breeze/cursors/size_ver<br />
cursors/Breeze/Breeze/cursors/split_h<br />
cursors/Breeze/Breeze/cursors/split_v<br />
cursors/Breeze/Breeze/cursors/text<br />
cursors/Breeze/Breeze/cursors/top_left_arrow<br />
cursors/Breeze/Breeze/cursors/top_left_corner<br />
cursors/Breeze/Breeze/cursors/top_right_corner<br />
cursors/Breeze/Breeze/cursors/top_side<br />
cursors/Breeze/Breeze/cursors/up-arrow<br />
cursors/Breeze/Breeze/cursors/v_double_arrow<br />
cursors/Breeze/Breeze/cursors/vertical-text<br />
cursors/Breeze/Breeze/cursors/w-resize<br />
cursors/Breeze/Breeze/cursors/wait<br />
cursors/Breeze/Breeze/cursors/watch<br />
cursors/Breeze/Breeze/cursors/wayland-cursor<br />
cursors/Breeze/Breeze/cursors/whats_this<br />
cursors/Breeze/Breeze/cursors/x-cursor<br />
cursors/Breeze/Breeze/cursors/xterm<br />
cursors/Breeze/Breeze/cursors/zoom-in<br />
cursors/Breeze/Breeze/cursors/zoom-out<br />
cursors/Breeze/Breeze/index.theme<br />
cursors/Breeze/CMakeLists.txt<br />
cursors/Breeze/build.sh<br />
cursors/Breeze/build/x1/alias.png<br />
cursors/Breeze/build/x1/all-scroll.png<br />
cursors/Breeze/build/x1/bottom_left_corner.png<br />
cursors/Breeze/build/x1/bottom_right_corner.png<br />
cursors/Breeze/build/x1/bottom_side.png<br />
cursors/Breeze/build/x1/cell.png<br />
cursors/Breeze/build/x1/center_ptr.png<br />
cursors/Breeze/build/x1/col-resize.png<br />
cursors/Breeze/build/x1/color-picker.png<br />
cursors/Breeze/build/x1/context-menu.png<br />
cursors/Breeze/build/x1/copy.png<br />
cursors/Breeze/build/x1/crosshair.png<br />
cursors/Breeze/build/x1/default.png<br />
cursors/Breeze/build/x1/dnd-move.png<br />
cursors/Breeze/build/x1/dnd-no-drop.png<br />
cursors/Breeze/build/x1/down-arrow.png<br />
cursors/Breeze/build/x1/draft.png<br />
cursors/Breeze/build/x1/fleur.png<br />
cursors/Breeze/build/x1/help.png<br />
cursors/Breeze/build/x1/left-arrow.png<br />
cursors/Breeze/build/x1/left_side.png<br />
cursors/Breeze/build/x1/no-drop.png<br />
cursors/Breeze/build/x1/not-allowed.png<br />
cursors/Breeze/build/x1/openhand.png<br />
cursors/Breeze/build/x1/pencil.png<br />
cursors/Breeze/build/x1/pirate.png<br />
cursors/Breeze/build/x1/pointer.png<br />
cursors/Breeze/build/x1/progress-01.png<br />
cursors/Breeze/build/x1/progress-02.png<br />
cursors/Breeze/build/x1/progress-03.png<br />
cursors/Breeze/build/x1/progress-04.png<br />
cursors/Breeze/build/x1/progress-05.png<br />
cursors/Breeze/build/x1/progress-06.png<br />
cursors/Breeze/build/x1/progress-07.png<br />
cursors/Breeze/build/x1/progress-08.png<br />
cursors/Breeze/build/x1/progress-09.png<br />
cursors/Breeze/build/x1/progress-10.png<br />
cursors/Breeze/build/x1/progress-11.png<br />
cursors/Breeze/build/x1/progress-12.png<br />
cursors/Breeze/build/x1/progress-13.png<br />
cursors/Breeze/build/x1/progress-14.png<br />
cursors/Breeze/build/x1/progress-15.png<br />
cursors/Breeze/build/x1/progress-16.png<br />
cursors/Breeze/build/x1/progress-17.png<br />
cursors/Breeze/build/x1/progress-18.png<br />
cursors/Breeze/build/x1/progress-19.png<br />
cursors/Breeze/build/x1/progress-20.png<br />
cursors/Breeze/build/x1/progress-21.png<br />
cursors/Breeze/build/x1/progress-22.png<br />
cursors/Breeze/build/x1/progress-23.png<br />
cursors/Breeze/build/x1/progress.png<br />
cursors/Breeze/build/x1/right-arrow.png<br />
cursors/Breeze/build/x1/right_ptr.png<br />
cursors/Breeze/build/x1/right_side.png<br />
cursors/Breeze/build/x1/row-resize.png<br />
cursors/Breeze/build/x1/size_bdiag.png<br />
cursors/Breeze/build/x1/size_fdiag.png<br />
cursors/Breeze/build/x1/size_hor.png<br />
cursors/Breeze/build/x1/size_ver.png<br />
cursors/Breeze/build/x1/text.png<br />
cursors/Breeze/build/x1/top_left_corner.png<br />
cursors/Breeze/build/x1/top_right_corner.png<br />
cursors/Breeze/build/x1/top_side.png<br />
cursors/Breeze/build/x1/up-arrow.png<br />
cursors/Breeze/build/x1/vertical-text.png<br />
cursors/Breeze/build/x1/wait-01.png<br />
cursors/Breeze/build/x1/wait-02.png<br />
cursors/Breeze/build/x1/wait-03.png<br />
cursors/Breeze/build/x1/wait-04.png<br />
cursors/Breeze/build/x1/wait-05.png<br />
cursors/Breeze/build/x1/wait-06.png<br />
cursors/Breeze/build/x1/wait-07.png<br />
cursors/Breeze/build/x1/wait-08.png<br />
cursors/Breeze/build/x1/wait-09.png<br />
cursors/Breeze/build/x1/wait-10.png<br />
cursors/Breeze/build/x1/wait-11.png<br />
cursors/Breeze/build/x1/wait-12.png<br />
cursors/Breeze/build/x1/wait-13.png<br />
cursors/Breeze/build/x1/wait-14.png<br />
cursors/Breeze/build/x1/wait-15.png<br />
cursors/Breeze/build/x1/wait-16.png<br />
cursors/Breeze/build/x1/wait-17.png<br />
cursors/Breeze/build/x1/wait-18.png<br />
cursors/Breeze/build/x1/wait-19.png<br />
cursors/Breeze/build/x1/wait-20.png<br />
cursors/Breeze/build/x1/wait-21.png<br />
cursors/Breeze/build/x1/wait-22.png<br />
cursors/Breeze/build/x1/wait-23.png<br />
cursors/Breeze/build/x1/wait.png<br />
cursors/Breeze/build/x1/wayland-cursor.png<br />
cursors/Breeze/build/x1/x-cursor.png<br />
cursors/Breeze/build/x1/zoom-in.png<br />
cursors/Breeze/build/x1/zoom-out.png<br />
cursors/Breeze/build/x1_5/alias.png<br />
cursors/Breeze/build/x1_5/all-scroll.png<br />
cursors/Breeze/build/x1_5/bottom_left_corner.png<br />
cursors/Breeze/build/x1_5/bottom_right_corner.png<br />
cursors/Breeze/build/x1_5/bottom_side.png<br />
cursors/Breeze/build/x1_5/cell.png<br />
cursors/Breeze/build/x1_5/center_ptr.png<br />
cursors/Breeze/build/x1_5/col-resize.png<br />
cursors/Breeze/build/x1_5/color-picker.png<br />
cursors/Breeze/build/x1_5/context-menu.png<br />
cursors/Breeze/build/x1_5/copy.png<br />
cursors/Breeze/build/x1_5/crosshair.png<br />
cursors/Breeze/build/x1_5/default.png<br />
cursors/Breeze/build/x1_5/dnd-move.png<br />
cursors/Breeze/build/x1_5/dnd-no-drop.png<br />
cursors/Breeze/build/x1_5/down-arrow.png<br />
cursors/Breeze/build/x1_5/draft.png<br />
cursors/Breeze/build/x1_5/fleur.png<br />
cursors/Breeze/build/x1_5/help.png<br />
cursors/Breeze/build/x1_5/left-arrow.png<br />
cursors/Breeze/build/x1_5/left_side.png<br />
cursors/Breeze/build/x1_5/no-drop.png<br />
cursors/Breeze/build/x1_5/not-allowed.png<br />
cursors/Breeze/build/x1_5/openhand.png<br />
cursors/Breeze/build/x1_5/pencil.png<br />
cursors/Breeze/build/x1_5/pirate.png<br />
cursors/Breeze/build/x1_5/pointer.png<br />
cursors/Breeze/build/x1_5/progress-01.png<br />
cursors/Breeze/build/x1_5/progress-02.png<br />
cursors/Breeze/build/x1_5/progress-03.png<br />
cursors/Breeze/build/x1_5/progress-04.png<br />
cursors/Breeze/build/x1_5/progress-05.png<br />
cursors/Breeze/build/x1_5/progress-06.png<br />
cursors/Breeze/build/x1_5/progress-07.png<br />
cursors/Breeze/build/x1_5/progress-08.png<br />
cursors/Breeze/build/x1_5/progress-09.png<br />
cursors/Breeze/build/x1_5/progress-10.png<br />
cursors/Breeze/build/x1_5/progress-11.png<br />
cursors/Breeze/build/x1_5/progress-12.png<br />
cursors/Breeze/build/x1_5/progress-13.png<br />
cursors/Breeze/build/x1_5/progress-14.png<br />
cursors/Breeze/build/x1_5/progress-15.png<br />
cursors/Breeze/build/x1_5/progress-16.png<br />
cursors/Breeze/build/x1_5/progress-17.png<br />
cursors/Breeze/build/x1_5/progress-18.png<br />
cursors/Breeze/build/x1_5/progress-19.png<br />
cursors/Breeze/build/x1_5/progress-20.png<br />
cursors/Breeze/build/x1_5/progress-21.png<br />
cursors/Breeze/build/x1_5/progress-22.png<br />
cursors/Breeze/build/x1_5/progress-23.png<br />
cursors/Breeze/build/x1_5/progress.png<br />
(675 more files...)</div></div></div><br /><div><strong>To: </strong>jamesl<br /><strong>Cc: </strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>