<table><tr><td style="">apol created this revision.<br />Restricted Application added a project: KWin.<br />Restricted Application added subscribers: KWin, kwin, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5232" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>I was trying to compile kwin and it was impossible to read the output because<br />
clang complains if it should override and it doesn't<br />
Something similar was done to Plasma as well.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5232" rel="noreferrer">https://phabricator.kde.org/D5232</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>abstract_client.h<br />
abstract_egl_backend.h<br />
activities.h<br />
autotests/fakeeffectplugin.cpp<br />
autotests/fakeeffectplugin_version.cpp<br />
autotests/integration/debug_console_test.cpp<br />
autotests/integration/helper/copy.cpp<br />
autotests/integration/helper/paste.cpp<br />
autotests/integration/internal_window.cpp<br />
autotests/integration/kwin_wayland_test.h<br />
autotests/integration/lockscreen.cpp<br />
autotests/integration/modifier_only_shortcut_test.cpp<br />
autotests/integration/plasmawindow_test.cpp<br />
autotests/integration/pointer_input.cpp<br />
autotests/mock_abstract_client.h<br />
autotests/mock_client.h<br />
autotests/mock_effectshandler.h<br />
autotests/mock_screens.h<br />
autotests/mock_workspace.h<br />
autotests/tabbox/mock_tabboxclient.h<br />
autotests/tabbox/mock_tabboxhandler.h<br />
autotests/test_window_paint_data.cpp<br />
client.h<br />
client_machine.h<br />
composite.h<br />
cursor.h<br />
dbusinterface.h<br />
debug_console.h<br />
decorations/decoratedclient.h<br />
decorations/decorationbridge.h<br />
decorations/decorationrenderer.h<br />
decorations/settings.h<br />
deleted.h<br />
effectloader.h<br />
effects.h<br />
effects/backgroundcontrast/contrast.h<br />
effects/blur/blur.h<br />
effects/blur/blur_config.h<br />
effects/blur/blurshader.h<br />
effects/colorpicker/colorpicker.h<br />
effects/coverswitch/coverswitch.h<br />
effects/coverswitch/coverswitch_config.h<br />
effects/cube/cube.h<br />
effects/cube/cube_config.h<br />
effects/cube/cube_inside.h<br />
effects/cube/cubeslide.h<br />
effects/cube/cubeslide_config.h<br />
effects/desktopgrid/desktopgrid.h<br />
effects/desktopgrid/desktopgrid_config.h<br />
effects/diminactive/diminactive.h<br />
effects/diminactive/diminactive_config.h<br />
effects/dimscreen/dimscreen.h<br />
effects/fallapart/fallapart.h<br />
effects/flipswitch/flipswitch.h<br />
effects/flipswitch/flipswitch_config.h<br />
effects/glide/glide.h<br />
effects/glide/glide_config.h<br />
effects/highlightwindow/highlightwindow.h<br />
effects/invert/invert.h<br />
effects/invert/invert_config.h<br />
effects/kscreen/kscreen.h<br />
effects/lookingglass/lookingglass.h<br />
effects/lookingglass/lookingglass_config.h<br />
effects/magiclamp/magiclamp.h<br />
effects/magiclamp/magiclamp_config.h<br />
effects/magnifier/magnifier.h<br />
effects/magnifier/magnifier_config.h<br />
effects/minimizeanimation/minimizeanimation.h<br />
effects/mouseclick/mouseclick.h<br />
effects/mouseclick/mouseclick_config.h<br />
effects/mousemark/mousemark.h<br />
effects/mousemark/mousemark_config.h<br />
effects/presentwindows/presentwindows.h<br />
effects/presentwindows/presentwindows_config.h<br />
effects/resize/resize.h<br />
effects/resize/resize_config.h<br />
effects/screenedge/screenedgeeffect.h<br />
effects/screenshot/screenshot.h<br />
effects/sheet/sheet.h<br />
effects/showfps/showfps.h<br />
effects/showfps/showfps_config.h<br />
effects/showpaint/showpaint.h<br />
effects/slide/slide.h<br />
effects/slideback/slideback.h<br />
effects/slidingpopups/slidingpopups.h<br />
effects/snaphelper/snaphelper.h<br />
effects/startupfeedback/startupfeedback.h<br />
effects/thumbnailaside/thumbnailaside.h<br />
effects/thumbnailaside/thumbnailaside_config.h<br />
effects/touchpoints/touchpoints.h<br />
effects/trackmouse/trackmouse.h<br />
effects/trackmouse/trackmouse_config.h<br />
effects/windowgeometry/windowgeometry.h<br />
effects/windowgeometry/windowgeometry_config.h<br />
effects/wobblywindows/wobblywindows.h<br />
effects/wobblywindows/wobblywindows_config.h<br />
effects/zoom/zoom.h<br />
effects/zoom/zoom_config.h<br />
focuschain.h<br />
geometrytip.h<br />
globalshortcuts.h<br />
helpers/xclipboardsync/waylandclipboard.h<br />
input.h<br />
kcmkwin/kwincompositing/compositing.h<br />
kcmkwin/kwincompositing/main.cpp<br />
kcmkwin/kwincompositing/model.h<br />
kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.h<br />
kcmkwin/kwindecoration/declarative-plugin/previewbridge.h<br />
kcmkwin/kwindecoration/declarative-plugin/previewbutton.h<br />
kcmkwin/kwindecoration/declarative-plugin/previewclient.h<br />
kcmkwin/kwindecoration/declarative-plugin/previewitem.h<br />
kcmkwin/kwindecoration/declarative-plugin/previewsettings.h<br />
kcmkwin/kwindecoration/decorationmodel.h<br />
kcmkwin/kwindecoration/kcm.h<br />
kcmkwin/kwindesktop/desktopnameswidget.h<br />
kcmkwin/kwindesktop/main.h<br />
kcmkwin/kwinoptions/main.h<br />
kcmkwin/kwinoptions/mouse.h<br />
kcmkwin/kwinoptions/windows.h<br />
kcmkwin/kwinrules/detectwidget.h<br />
kcmkwin/kwinrules/kcm.h<br />
kcmkwin/kwinrules/ruleslist.h<br />
kcmkwin/kwinrules/ruleswidget.h<br />
kcmkwin/kwinscreenedges/main.h<br />
kcmkwin/kwinscreenedges/monitor.h<br />
kcmkwin/kwinscreenedges/screenpreviewwidget.h<br />
kcmkwin/kwinscripts/module.h<br />
kcmkwin/kwintabbox/layoutpreview.h<br />
kcmkwin/kwintabbox/main.h<br />
kcmkwin/kwintabbox/thumbnailitem.h<br />
keyboard_input.h<br />
lanczosfilter.h<br />
libinput/connection.cpp<br />
libinput/connection.h<br />
libinput/device.h<br />
libinput/events.h<br />
libkwineffects/kwinanimationeffect.h<br />
libkwineffects/kwineffects.h<br />
logind.h<br />
main.h<br />
main_wayland.h<br />
main_x11.h<br />
netinfo.h<br />
options.h<br />
outline.h<br />
platform.h<br />
plugins/idletime/poller.h<br />
plugins/kdecorations/aurorae/src/aurorae.h<br />
plugins/kdecorations/aurorae/src/colorhelper.h<br />
plugins/kdecorations/aurorae/src/decorationoptions.h<br />
plugins/kdecorations/aurorae/src/decorationplugin.h<br />
plugins/kdecorations/aurorae/src/lib/auroraetheme.h<br />
plugins/kdecorations/aurorae/themes/plastik/code/plastikbutton.h<br />
plugins/kdecorations/aurorae/themes/plastik/code/plastikplugin.h<br />
plugins/kglobalaccel/kglobalaccel_plugin.h<br />
plugins/platforms/drm/drm_backend.h<br />
plugins/platforms/drm/drm_inputeventfilter.h<br />
plugins/platforms/drm/drm_object_connector.h<br />
plugins/platforms/drm/drm_object_crtc.h<br />
plugins/platforms/drm/drm_object_plane.h<br />
plugins/platforms/drm/drm_output.h<br />
plugins/platforms/drm/egl_gbm_backend.h<br />
plugins/platforms/drm/scene_qpainter_drm_backend.h<br />
plugins/platforms/drm/screens_drm.h<br />
plugins/platforms/fbdev/fb_backend.h<br />
plugins/platforms/fbdev/scene_qpainter_fb_backend.h<br />
plugins/platforms/virtual/egl_gbm_backend.h<br />
plugins/platforms/virtual/scene_qpainter_virtual_backend.h<br />
plugins/platforms/virtual/screens_virtual.h<br />
plugins/platforms/virtual/virtual_backend.h<br />
plugins/platforms/wayland/egl_wayland_backend.h<br />
plugins/platforms/wayland/scene_qpainter_wayland_backend.h<br />
plugins/platforms/wayland/wayland_backend.h<br />
plugins/platforms/x11/common/eglonxbackend.h<br />
plugins/platforms/x11/standalone/edge.h<br />
plugins/platforms/x11/standalone/glxbackend.h<br />
plugins/platforms/x11/standalone/screens_xrandr.h<br />
plugins/platforms/x11/standalone/windowselector.h<br />
plugins/platforms/x11/standalone/x11_platform.h<br />
plugins/platforms/x11/standalone/x11cursor.h<br />
plugins/platforms/x11/standalone/xinputintegration.cpp<br />
plugins/platforms/x11/standalone/xinputintegration.h<br />
plugins/platforms/x11/windowed/egl_x11_backend.h<br />
plugins/platforms/x11/windowed/scene_qpainter_x11_backend.h<br />
plugins/platforms/x11/windowed/x11windowed_backend.h<br />
plugins/qpa/abstractplatformcontext.h<br />
plugins/qpa/backingstore.h<br />
plugins/qpa/integration.h<br />
plugins/qpa/platformcursor.h<br />
plugins/qpa/screen.h<br />
plugins/qpa/window.h<br />
pointer_input.h<br />
rules.h<br />
scene.h<br />
scene_opengl.h<br />
scene_qpainter.h<br />
scene_xrender.h<br />
screenedge.h<br />
screenlockerwatcher.h<br />
screens.h<br />
scripting/dbuscall.h<br />
scripting/genericscriptedconfig.h<br />
scripting/screenedgeitem.h<br />
scripting/scriptedeffect.h<br />
scripting/scripting.h<br />
scripting/scripting_model.h<br />
shadow.h<br />
shell_client.h<br />
sm.h<br />
tabbox/clientmodel.h<br />
tabbox/desktopchain.h<br />
tabbox/desktopmodel.h<br />
tabbox/switcheritem.h<br />
tabbox/tabbox.h<br />
tabbox/tabboxhandler.h<br />
tests/pointergesturestest.cpp<br />
tests/screenedgeshowtest.cpp<br />
tests/waylandclienttest.h<br />
thumbnailitem.h<br />
toplevel.h<br />
touch_input.h<br />
unmanaged.h<br />
useractions.h<br />
utils.h<br />
virtual_terminal.h<br />
virtualdesktops.h<br />
virtualkeyboard.h<br />
wayland_cursor_theme.h<br />
wayland_server.h<br />
workspace.h</div></div></div><br /><div><strong>To: </strong>apol, Plasma, graesslin, davidedmundson<br /><strong>Cc: </strong>plasma-devel, kwin, KWin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol<br /></div>