<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5182" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5182#inline-21330" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pointer_input.cpp:234-236</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">s_scheduledPositions</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">pos</span> <span style="color: #aa2211">=</span> <span class="n">s_scheduledPositions</span><span class="p">.</span><span class="n">takeFirst</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">m_pointer</span><span style="color: #aa2211">-></span><span class="n">processMotion</span><span class="p">(</span><span class="n">pos</span><span class="p">.</span><span class="n">pos</span><span class="p">,</span> <span class="n">pos</span><span class="p">.</span><span class="n">delta</span><span class="p">,</span> <span class="n">pos</span><span class="p">.</span><span class="n">deltaNonAccelerated</span><span class="p">,</span> <span class="n">pos</span><span class="p">.</span><span class="n">time</span><span class="p">,</span> <span class="n">pos</span><span class="p">.</span><span class="n">timeUsec</span><span class="p">,</span> <span style="color: #aa4000">nullptr</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This can lead to strange side effect</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">isPositionBlocked == true</li>
<li class="remarkup-list-item">s_scheduledPositions.size() > 1</li>
<li class="remarkup-list-item">isPositionBlocked == false</li>
<li class="remarkup-list-item">s_scheduledPositions.size() - 1 but still not 0</li>
</ol>

<p style="padding: 0; margin: 8px;">In next block/unblock will be triggered pertty old motion event, no? Maybe it's better to steal all blocked events except last one.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5182" rel="noreferrer">https://phabricator.kde.org/D5182</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: </strong>anthonyfieroni, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol<br /></div>