<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4806" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Since there seem to be not many others I'll try to give you reviews for this and your following patches, but first I've to understand this stuff.</p>
<p>Tell me if the following is right:</p>
<p>Until now the greeter waited for the exit code of the forked process with the pid <tt style="background: #ebebeb; font-size: 13px;">m_pid</tt>. The child process executes the kcheckpass binary via execlp for pam/etcshadow password validation and exits immediately. The parent process now reads the requests and results from kcheckpass via socket <tt style="background: #ebebeb; font-size: 13px;">m_fd</tt>. It gets notified when kcheckpass has written something to the socket thanks to <tt style="background: #ebebeb; font-size: 13px;">m_notifier</tt>.</p>
<p>First kcheckpass's pam/etcshadows part asks for the provided password, i.e. transmits <tt style="background: #ebebeb; font-size: 13px;">ConvGetNormal</tt> / <tt style="background: #ebebeb; font-size: 13px;">ConvGetHidden</tt>, so <tt style="background: #ebebeb; font-size: 13px;">KCheckPass::handleVerify</tt> writes back the provided password to the socket. kcheckpass can apparently without having to wait directly read it from the socket. Pam/etcshadow compares it with the set user password and (until now) exits with the respective success or fail code.</p>
<p>With your change instead of setting an exit code conv_server writes back one more time to the socket with the result (i.e. only the enum signaling it with empty prompt).</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4806#inline-21073" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">authenticator.cpp:221</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">case</span> <span style="color: #a0a000">ConvGetHidden</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">GRecvArr</span><span class="p">(</span> <span style="color: #aa2211">&</span><span class="n">arr</span> <span class="p">))</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">When you're at it: This seems to do the exact same thing as in <tt style="background: #ebebeb; font-size: 13px;">ConvGetNormal</tt> case. Code duplication?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4806#inline-21075" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">authenticator.cpp:270</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">errno</span> <span style="color: #aa2211">!=</span> <span class="n">EINTR</span><span class="p">)</span> <span class="p">{</span> <span style="color: #74777d">// This should not happen ...</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">cantCheck</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">When we have already received <tt style="background: #ebebeb; font-size: 13px;">ConvPutAuthSucceeded</tt> this would mean that we first emitted <tt style="background: #ebebeb; font-size: 13px;">succeeded</tt> and later <tt style="background: #ebebeb; font-size: 13px;">failed</tt>, which could lead to problems. Just delete the whole reapVerify method and end <tt style="background: #ebebeb; font-size: 13px;">m_notifier</tt> as well as close <tt style="background: #ebebeb; font-size: 13px;">m_fd</tt> in handleVerify.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R133 KScreenLocker</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4806" rel="noreferrer">https://phabricator.kde.org/D4806</a></div></div><br /><div><strong>To: </strong>graesslin, Plasma<br /><strong>Cc: </strong>subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>