<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5106" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>mostly looks fine. Only one major comment about the return after handling client edges.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5106#inline-20937" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gestures.cpp:61</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> <span class="n">Direction</span><span style="color: #aa2211">::</span><span style="color: #a0a000">Right</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">min</span><span class="p">(</span><span class="n">std</span><span style="color: #aa2211">::</span><span class="n">abs</span><span class="p">(</span><span class="n">delta</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">/</span> <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">abs</span><span class="p">(</span><span class="n">m_minimumDelta</span><span class="p">.</span><span class="n">width</span><span class="p">()),</span> <span style="color: #601200">1.0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">default</span><span style="color: #aa2211">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">having negatives in minimumDelta would make no sense in the first place..</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5106#inline-20935" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screenedge.cpp:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">,</span> <span class="n">m_client</span><span class="p">(</span><span style="color: #aa4000">nullptr</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">,</span> <span class="n">m_gesture</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">SwipeGesture</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">who owns SwipeGesture?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5106#inline-20931" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screenedge.cpp:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_client</span><span style="color: #aa2211">-></span><span class="n">showOnScreenEdge</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">unreserve</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">equivalent ::handle() code returns after this.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5106#inline-20930" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screenedge.cpp:92</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_gesture</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">SwipeGesture</span><span style="color: #aa2211">::</span><span class="n">cancelled</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">Edge</span><span style="color: #aa2211">::</span><span class="n">stopApproaching</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_gesture</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">SwipeGesture</span><span style="color: #aa2211">::</span><span class="n">triggered</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">Edge</span><span style="color: #aa2211">::</span><span class="n">stopApproaching</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_gesture</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">SwipeGesture</span><span style="color: #aa2211">::</span><span class="n">progress</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">maybe we want to do this inside the triggered lambda above, otherwise we call stopApproaching, before handling the trigger which is queued.</p>
<p style="padding: 0; margin: 8px;">If our wayland side ever gets a doStopApproaching, it might result in being a bit out of order</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5106#inline-20934" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screenedge.cpp:473</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">isScreenEdge</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">m_edges</span><span style="color: #aa2211">-></span><span class="n">isDesktopSwitching</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_edges</span><span style="color: #aa2211">-></span><span class="n">gestureRecognizer</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">registerGesture</span><span class="p">(</span><span class="n">m_gesture</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Note that the only subclass of Edge doesn't call the super class for any of the virtual methods: doGeom/activate/deactivate.</p>
<p style="padding: 0; margin: 8px;">To fit the current pattern this should be in setGeometry / reserve / unreserve respectively</p>
<p style="padding: 0; margin: 8px;">(and yes, I know the current only subclass of Edge isn't relevant in this case)</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5106" rel="noreferrer">https://phabricator.kde.org/D5106</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland<br /><strong>Cc: </strong>davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol<br /></div>