<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4718" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4718#95190" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D4718#95190</a>, <a href="https://phabricator.kde.org/p/graesslin/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>This broke a unit test: <a href="https://build.kde.org/user/graesslin/my-views/view/mgraesslin%20maintained/job/kwin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/554/testReport/junit/(root)/TestSuite/kwin_testScreenEdges/" class="remarkup-link" target="_blank" rel="noreferrer">https://build.kde.org/user/graesslin/my-views/view/mgraesslin%20maintained/job/kwin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/554/testReport/junit/(root)/TestSuite/kwin_testScreenEdges/</a></p></div>
</blockquote>

<p>this seems because of the patch in line 989 it's now destroying the edge pointer when the edge is reassigned, which i think it's fine, i see some options:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">remove the test, because the deletion of the edge pointer makes sense</li>
<li class="remarkup-list-item">reintroduce the check in line 989, but checking also the geometry isn't changed: this would need also tracking the actual client geometry in the edge class to be able to compare it (delete the edge only if the geometry changed)</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4718" rel="noreferrer">https://phabricator.kde.org/D4718</a></div></div><br /><div><strong>To: </strong>mart, graesslin, Plasma<br /><strong>Cc: </strong>luebking, plasma-devel, kwin, KWin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol<br /></div>