<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4893" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Honestly I don't think it's a good idea to animate the y position of the main stack. I fear this can result in a completely unusable lock screen as the main elements might get outside the visible area. I had huge problems with the layout of the lockscreen and fiddled quite a bit till I had it working correctly. Compare the problems with the Clock and scaling. I went for overlapping with parts of the UI for a reason as I don't think we have enough screen estate to show both the full UI and the keyboard.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4893#inline-20684" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockScreenUi.qml:71</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #004012"><span class="bright">Item</span></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #004012"><span class="bright">MouseArea</span></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">id: lockScreenRoot</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why the change to MouseArea?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4893#inline-20685" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockScreenUi.qml:81</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">onClicked:</span> <span style="color: #004012">inputPanel</span><span class="p">.</span><span style="color: #004012">state</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"hidden"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is not related to the described change. Do we really want to close when clicking outside the keyboard? That could be rather annoying? Anyway I think it should not be bundled with a change saying it's about animations</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4893#inline-20686" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockScreenUi.qml:113</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">Clock</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">anchors.bottom:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">parent</span></span><span class="p">.</span><span style="color: #004012">verticalCenter</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.bottom:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">mainStack</span></span><span class="p">.</span><span style="color: #004012">verticalCenter</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">anchors.bottomMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span style="color: #601200">13</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could you please rebase this to the changes introduces with <a href="https://phabricator.kde.org/R120:097db85e297aba8b4b3f0ddabcddf8a03b5482c0" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">097db85e297aba8b4b3f0ddabcddf8a03b5482c0</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4893#inline-20687" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockScreenUi.qml:221</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">target:</span> <span style="color: #004012">inputPanel</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">y:</span> <span style="color: #004012">lockScreenRoot</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">-</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span style="color: #601200">10</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">opacity:</span> <span style="color: #601200">0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm especially afraid of reintroducing units here with a fixed multiplier. That was exactly the thing causing problems with scaling and the clock.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4893" rel="noreferrer">https://phabricator.kde.org/D4893</a></div></div><br /><div><strong>To: </strong>mart, Plasma, graesslin<br /><strong>Cc: </strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>