<table><tr><td style="">dhaumann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5034" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Just some minor comments, besides that, looks sane.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5034#inline-20594" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fstabdevice.cpp:40-41</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_device</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span style="color: #766510">"//"</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_<span class="bright">product</span></span> <span style="color: #aa2211">=</span> <span class="n">m_device</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span><span style="color: #601200">2</span><span class="p">,</span> <span class="n">m_device</span><span class="p">.</span><span class="n">indexOf</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"/"</span></span><span class="p">,</span> <span style="color: #601200">2</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span style="color: #601200">2</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_<span class="bright">vendor</span></span> <span style="color: #aa2211">=</span> <span class="n">m_device</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span><span class="n">m_device</span><span class="p">.</span><span class="n">indexOf</span><span class="p">(</span><span style="color: #766510">"/"</span><span class="p">,</span> <span style="color: #601200">2</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_device</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"//"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_<span class="bright">vendor</span></span> <span style="color: #aa2211">=</span> <span class="n">m_device</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span><span style="color: #601200">2</span><span class="p">,</span> <span class="n">m_device</span><span class="p">.</span><span class="n">indexOf</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"/"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>,</span> <span style="color: #601200">2</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span style="color: #601200">2</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_<span class="bright">product</span></span> <span style="color: #aa2211">=</span> <span class="n">m_device</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span><span class="n">m_device</span><span class="p">.</span><span class="n">indexOf</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"/"</span><span class="p">,</span> <span style="color: #601200">2<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>)</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Did you intentionally switch vendor and product?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5034#inline-20590" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fstabdevice.cpp:51</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">option</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"x-gvfs-name="</span><span class="p">)))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">encoded</span> <span style="color: #aa2211">=</span> <span class="n">option</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span><span class="n">option</span><span class="p">.</span><span class="n">indexOf</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"="</span><span class="p">),</span> <span style="color: #601200">11</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_description</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromPercentEncoding</span><span class="p">(</span><span class="n">encoded</span><span class="p">.</span><span class="n">toLatin1</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QStringRef through midRef()</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5034#inline-20591" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fstabdevice.cpp:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">option</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"x-gvfs-icon="</span><span class="p">)))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">encoded</span> <span style="color: #aa2211">=</span> <span class="n">option</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span><span class="n">option</span><span class="p">.</span><span class="n">indexOf</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"="</span><span class="p">),</span> <span style="color: #601200">11</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_iconName</span> <span style="color: #aa2211">=</span> <span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">fromPercentEncoding</span><span class="p">(</span><span class="n">encoded</span><span class="p">.</span><span class="n">toLatin1</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">likewise, use QStringRef</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5034#inline-20593" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fstabhandling.cpp:146</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">mountpoint</span> <span style="color: #aa2211">=</span> <span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">decodeName</span><span class="p">(</span><span class="n">fe</span><span style="color: #aa2211">-></span><span class="n">mnt_dir</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span class="n">options</span> <span style="color: #aa2211">=</span> <span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">decodeName</span><span class="p">(</span><span class="n">fe</span><span style="color: #aa2211">-></span><span class="n">mnt_opts</span><span class="p">).</span><span class="n">split</span><span class="p">(</span><span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">','</span><span class="p">),</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">SkipEmptyParts</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If you save the decodedName, you could also call splitRef() to avoid more allocations.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5034" rel="noreferrer">https://phabricator.kde.org/D5034</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, dfaure<br /><strong>Cc: </strong>dhaumann, plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>