<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5036" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Background is quite dark for me now :/</p>
<p>Also, can we perhaps have pressing the arrow keys cancel the timer? It's quite unintuitive that when I press left the label still says "Logging out in n seconds" although Shutdown is highlighted.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5036#inline-20566" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">shutdowndlg.cpp:200</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QColor</span> <span class="n">backgroundColor</span> <span style="color: #aa2211">=</span> <span class="n">rootObject</span><span class="p">()</span> <span style="color: #aa2211">?</span> <span class="n">rootObject</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">(</span><span style="color: #766510">"backgroundColor"</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QColor</span><span style="color: #aa2211">></span><span class="p">()</span> <span style="color: #aa2211">:</span> <span class="n">QColor</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KWindowEffects</span><span style="color: #aa2211">::</span><span class="n">enableBackgroundContrast</span><span class="p">(</span><span class="n">winId</span><span class="p">(),</span> <span style="color: #304a96">true</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #601200">0.4</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">From what I can tell KWin doesn't support different background contrasts, ie. once you click Leave you'll change your Panel background contrast.</p>
<p style="padding: 0; margin: 8px;">Bhushan experienced the same when running a plasmoid in plasmoidviewer using a different theme, as soon as a tooltip shows up, it globally changes the contrast.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5036#inline-20567" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">shutdowndlg.cpp:229</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">switch</span> <span class="p">(</span><span class="n">pe</span><span style="color: #aa2211">-></span><span class="n">surfaceEventType</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span class="n">QPlatformSurfaceEvent</span><span style="color: #aa2211">::</span><span style="color: #a0a000">SurfaceCreated</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> <span class="n">QPlatformSurfaceEvent</span><span style="color: #aa2211">::</span><span style="color: #a0a000">SurfaceCreated</span><span class="p">:<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">setupWaylandIntegration</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5036#inline-20568" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Logout.qml:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">property:</span> <span style="color: #766510">"opacity"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">target:</span> <span style="color: #004012">shutdownDialog</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">from:</span> <span style="color: #601200">0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't let Martin see that you animate a window opacity manually</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5036#inline-20569" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Logout.qml:94</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">function</span> <span style="color: #004012">rgbToHsv</span><span class="p">(</span><span style="color: #004012">color</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">var</span> <span style="color: #004012">max</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">r</span><span class="p">,</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">g</span><span class="p">,</span> <span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">b</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Urgh. Can you add a TODO for Qt 5.8 :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5036#inline-20570" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Logout.qml:217</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">enabled:</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">currentAction</span> <span style="color: #aa2211">!=</span> <span style="color: #000a65">null</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">i18nd</span><span class="p">(</span><span style="color: #766510">"plasma_lookandfeel_org.kde.lookandfeel"</span><span class="p">,</span> <span style="color: #766510">"Ok"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">onClicked:</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">currentAction</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Isn't it "OK"?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5036" rel="noreferrer">https://phabricator.kde.org/D5036</a></div></div><br /><div><strong>To: </strong>mart, Plasma, sebas<br /><strong>Cc: </strong>broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>