<table><tr><td style="">volkov added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4939" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20177" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:111</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">qt5_add_dbus_adaptor(powerdevil_SRCS ${<span class="bright">KDE4</span>_DBUS_INTERFACES_DIR}/kf5_org.freedesktop.PowerManagement.xml powerdevilfdoconnector.h PowerDevil::FdoConnector powermanagementfdoadaptor PowerManagementFdoAdaptor)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">qt5_add_dbus_adaptor(powerdevil_SRCS ${<span class="bright">KDE4</span>_DBUS_INTERFACES_DIR}/kf5_org.freedesktop.PowerManagement.Inhibit.xml powerdevilfdoconnector.h PowerDevil::FdoConnector powermanagementinhibitadaptor PowerManagementInhibitAdaptor)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">qt5_add_dbus_adaptor(powerdevil_SRCS ${<span class="bright">SOLID</span>_DBUS_INTERFACES_DIR}/kf5_org.freedesktop.PowerManagement.xml powerdevilfdoconnector.h PowerDevil::FdoConnector powermanagementfdoadaptor PowerManagementFdoAdaptor)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">qt5_add_dbus_adaptor(powerdevil_SRCS ${<span class="bright">SOLID</span>_DBUS_INTERFACES_DIR}/kf5_org.freedesktop.PowerManagement.Inhibit.xml powerdevilfdoconnector.h PowerDevil::FdoConnector powermanagementinhibitadaptor PowerManagementInhibitAdaptor)
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I guess it can be just removed. These kf5_org.* files were dropped from solid three years ago.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20178" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">add_powerdevil_bundled_action(runscript KF5::KIOCore KF5::KIOWidgets)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">add_powerdevil_bundled_action(suspendsession KF5::KIOCore KF5::KIOWidgets KF5::Solid<span class="bright"> KF5::KDELibs4Support</span>)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">add_powerdevil_bundled_action(suspendsession KF5::KIOCore KF5::KIOWidgets KF5::Solid)
</div><div style="padding: 0 8px; margin: 0 4px; ">if(HAVE_WIRELESS_SUPPORT)
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is it necessary to add KF5::Solid?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20186" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powerdevilcore.cpp:102</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_backend</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span class="n">BackendInterface</span><span style="color: #aa2211">::</span><span class="n">UnknownSuspendMethod</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">And who will set backend for Core?</p>

<p style="padding: 0; margin: 8px;">Now I think that it was a bad idea to request supported suspend methods from a backend, <br />
because GUI doesn't depend on it. You need to load the backend in GUI, it will do some initialization...</p>

<p style="padding: 0; margin: 8px;">It seems to be more reasonable to request supported methods from powerdevil daemon by dbus calllings<br />
org.freedesktop.PowerManagement.{CanSuspend, CanHibernate, CanHybridSuspend}</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20187" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powerdevilcore.cpp:107</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">Core</span><span style="color: #aa2211">::</span><span class="n">generateDefaultProfiles</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20188" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">activitypage.cpp:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// Message widget</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_messageWidget</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KMessageWidget</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"The activity service is running with bare functionalities.</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                                                          <span style="color: #766510">"Names and icons of the activities might not be available."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_messageWidget</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">QSharedPointer</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">KMessageWidget</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #aa4000">new</span> <span class="n">KMessageWidget</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"The activity service is running with bare functionalities.</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                          <span class="bright">                   </span><span style="color: #766510">"Names and icons of the activities might not be available."<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Shouldn't it be in a separate change?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R122 Powerdevil</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4939" rel="noreferrer">https://phabricator.kde.org/D4939</a></div></div><br /><div><strong>To: </strong>denisshienkov, volkov, afiestas<br /><strong>Cc: </strong>graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>