<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129995/">https://git.reviewboard.kde.org/r/129995/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129995/diff/1/?file=492315#file492315line185" style="color: black; font-weight: bold; text-decoration: underline;">runners/kill/killrunner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">185</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KProcess</span> <span class="o">*</span><span class="n">process</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KProcess</span><span class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">185</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KProcess</span> <span class="o">*</span><span class="n">process</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KProcess</span><span class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just put it on the stack, that way you don't have to worry about any manual deletions.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Or use the static QProcess::execute which wraps it all anyway.</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On March 7th, 2017, 7:15 a.m. UTC, Leslie Zhai wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez and Kai Uwe Broulik.</div>
<div>By Leslie Zhai.</div>
<p style="color: grey;"><i>Updated March 7, 2017, 7:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi KDE developers,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bug reported by the clang static analyzer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Description: Potential leak of memory pointed to by 'process'
File: plasma-workspace/runners/kill/killrunner.cpp
Line: 186</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>168 void KillRunner::run(const Plasma::RunnerContext &context, const Plasma::QueryMatch &match)
169 {
170 Q_UNUSED(context)
171
172 QVariantList data = match.data().value<QVariantList>();
173 quint64 pid = data[0].toUInt();
174 // QString user = data[1].toString();
175
176 int signal;
177 if (match.selectedAction() != NULL) {
Assuming the condition is false
?
?
Taking false branch
?
178 signal = match.selectedAction()->data().toInt();
179 } else {
180 signal = 9; //default: SIGKILL
181 }
182
183 QStringList args;
184 args << QStringLiteral("-%1").arg(signal) << QStringLiteral("%1").arg(pid);
185 KProcess *process = new KProcess(this);
?
Memory is allocated
?
186 int returnCode = process->execute(QStringLiteral("kill"), args);
?
Within the expansion of the macro 'QStringLiteral':
a
Potential leak of memory pointed to by 'process'
187
188 if (returnCode == 0)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So I simply add <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">delete process</code> to free the allocated memory.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regards,
Leslie Zhai</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/kill/killrunner.cpp <span style="color: grey">(5c2e8529)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129995/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>